[pkg-php-pear] adding nocheck and stage1 (bootstrapping build profiles)

[Nish Aravamudan]

On 02.06.2016 [20:52:34 -0400], "David Prévot" wrote:
> Hi,
> 
> > I don't want to send a bunch of
> > patches that are basically noise. Thoughts?
> [
]
> > E.g.:
> [
]
> > -               phpunit,
> > +               phpunit <!nocheck !stage1>,
> [
]
> > -ifeq (,$(findstring nocheck, $(DEB_BUILD_OPTIONS)))
> > +ifeq (,$(filter nocheck stage1, $(DEB_BUILD_OPTIONS)
> 
> Assuming this syntax won’t mess up with the current Debian
> toolchain, and that it had already at least some testing in your usual
> setup, why not just commit your patches directly in the repositories?

Ack, I can do that -- I'm just hesitant to make too many changes without
some consultation first.

It should have no impact on the current Debian toolchain, as it's fully
supported there.

> Prach and Daniel are the other two main involved in the PHPUnit and
> Symfony front, so they may have an other view on the matter, but if nobody
> disagrees, I believe we would welcome your contributions.

Great, thanks!

> I’m aware about work in progress in the build profiles front [0], but
> since it’s not properly usable in Debian infrastructure yet TTBOMK, I
> haven’t bothered to put my head into it for the moment.
> 
>    0: https://wiki.debian.org/BuildProfileSpec

Yeah, we actually wouldn't have been able to use it in Ubuntu proper
either (without some manual build steps) -- but having it there meant I
could at least test my changes locally, etc.

Thanks for the prompt feedback, I'll start pushing my changes to the git
repositories if I hear no objections in the meanwhile!

Thanks,
Nish