[pkg-php-pear] Bug#903623: php-doctrine-dbal: not NMU/binNMU safe

[Gianfranco Costamagna]

Package: php-doctrine-dbal
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu cosmic ubuntu-patch
Version: 2.7.1-1
Severity: serious
Tags: patch

Hello dear maintainer,
In ubuntu we do alredy binNMUs, and your package badly fails to parse the changelog entry.

e.g.

echo "php-doctrine-dbal (2.7.1-1+b1) unstable; urgency=medium" | sed 's/.*(//;s/-.?*).*//'
2.7.1-1+b1) unstable; urgency=medium

while works on the normal versioning
echo "php-doctrine-dbal (2.7.1-1) unstable; urgency=medium" | sed 's/.*(//;s/-.?*).*//'
2.7.1


echo "php-doctrine-dbal (2.7.1-1.1) unstable; urgency=medium" | sed 's/.*(//;s/-.?*).*//'
2.7.1-1.1) unstable; urgency=medium


this leads to a help2man failure due to the ")" character.

the following patch fixes the issue in the right way (TM), thanks to a "new" dpkg feature.

--- php-doctrine-dbal-2.7.1/debian/rules	2017-08-29 07:53:37.000000000 +0200
+++ php-doctrine-dbal-2.7.1/debian/rules	2018-07-12 00:31:48.000000000 +0200
@@ -1,6 +1,7 @@
 #!/usr/bin/make -f
 
-UPSTREAM := $(shell head -1 debian/changelog | sed 's/.*(//;s/-.?*).*//')
+include /usr/share/dpkg/default.mk
+UPSTREAM := $(DEB_VERSION_UPSTREAM)
 
 %:
 	dh $@ --with phpcomposer -XREADME.markdown


thanks for considering it

Gianfranco