[pkg-php-pear] Bug#934647: symfony: autopkgtest should unset http proxy

[Steve Langasek]

Package: symfony
Version: 4.3.3+dfsg-3
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu eoan ubuntu-patch

Dear maintainers,

The autopkgtests in the newer upstream version of symfony, 4.3.3, are
failing in Ubuntu because they are trying to talk to a local test http
server and symfony honors the http_proxy variable, which is set:

[...]
2) Symfony\Component\HttpClient\Tests\CurlHttpClientTest::testQuery
Symfony\Component\HttpClient\Exception\ServerException: HTTP/1.1 503 Service Unavailable returned for "http://localhost:8057/?a=a&b=b".
[...]

(https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-eoan/eoan/amd64/s/symfony/20190801_161112_eb4c2@/log.gz)

I think the simplest fix for this is to unset http_proxy in the autopkgtest,
since symfony's test suite shouldn't need to talk to any *non*-local
webservers.

Thanks for considering the patch.
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru symfony-4.3.3+dfsg/debian/tests/phpunit symfony-4.3.3+dfsg/debian/tests/phpunit
--- symfony-4.3.3+dfsg/debian/tests/phpunit	2019-08-01 00:38:50.000000000 -0700
+++ symfony-4.3.3+dfsg/debian/tests/phpunit	2019-08-12 15:16:26.000000000 -0700
@@ -1,6 +1,9 @@
 #!/bin/bash
 set -e
 
+# we only access local servers, so just unset any proxy setting
+unset http_proxy
+
 # This test fails on s390x
 if [ `dpkg --print-architecture` = 's390x' ] ; then
   echo "Don't fail testsuite on s390x, this test always failed there"