[pkg-php-pear] Bug#919816: symfony: autopkgtest needs update for new version of php7.3

[Paul Gevers]

Source: symfony
Version: 3.4.21+dfsg-1
X-Debbugs-CC: debian-ci at lists.debian.org, php7.3 at packages.debian.org
User: debian-ci at lists.debian.org
Usertags: needs-update
Control: affects -1 src:php7.3

Dear maintainers,

With a recent upload of php7.3 the autopkgtest of symfony fails in
testing when that autopkgtest is run with the binary packages of php7.3
from unstable. It passes when run with only packages from testing. In
tabular form:
                       pass            fail
php7.3                 from testing    7.3.1-1
symfony                from testing    3.4.21+dfsg-1
versioned deps [0]     from testing    from unstable
all others             from testing    from testing

I copied some of the output at the bottom of this report. It seems you
need to update your references.

Currently this regression is blocking the migration of php7.3 to testing
[1]. Of course, php7.3 shouldn't just break your autopkgtest (or even
worse, your package), but it seems to me that the change in php7.3 was
intended and your package needs to update to the new situation. If
needed, please change the bug's severity.

If this is a real problem in your package (and not only in your
autopkgtest), the right binary package(s) from php7.3 should really add
a versioned Breaks on the unfixed version of (one of your) package(s).
Note: the Breaks is nice even if the issue is only in the autopkgtest as
it helps the migration software to figure out the right versions to
combine in the tests.

More information about this bug and the reason for filing it can be found on
https://wiki.debian.org/ContinuousIntegration/RegressionEmailInformation

Paul

[0] You can see what packages were added from the second line of the log
file quoted below. The migration software adds source package from
unstable to the list if they are needed to install packages from
php7.3/7.3.1-1. I.e. due to versioned dependencies or breaks/conflicts.
[1] https://qa.debian.org/excuses.php?package=php7.3

https://ci.debian.net/data/autopkgtest/testing/amd64/s/symfony/1736808/log.gz
There were 7 failures:

1) Symfony\Bridge\Twig\Tests\Node\FormThemeTest::testCompile
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'$this->env->getRuntime("Symfony\\Component\\Form\\FormRenderer")->setTheme(($context["form"]
?? null), array(0 => "tpl1", 1 => "tpl2"), true);'
+'$this->env->getRuntime("Symfony\\Component\\Form\\FormRenderer")->setTheme(($context["form"]
?? null), [0 => "tpl1", 1 => "tpl2"], true);'

/tmp/autopkgtest-lxc.p99bggf8/downtmp/build.az6/src/src/Symfony/Bridge/Twig/Tests/Node/FormThemeTest.php:67

2)
Symfony\Bridge\Twig\Tests\Node\SearchAndRenderBlockNodeTest::testCompileWidgetWithVariables
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'$this->env->getRuntime('Symfony\Component\Form\FormRenderer')->searchAndRenderBlock(($context["form"]
?? null), 'widget', array("foo" => "bar"))'
+'$this->env->getRuntime('Symfony\Component\Form\FormRenderer')->searchAndRenderBlock(($context["form"]
?? null), 'widget', ["foo" => "bar"])'

/tmp/autopkgtest-lxc.p99bggf8/downtmp/build.az6/src/src/Symfony/Bridge/Twig/Tests/Node/SearchAndRenderBlockNodeTest.php:64

3)
Symfony\Bridge\Twig\Tests\Node\SearchAndRenderBlockNodeTest::testCompileLabelWithLabel
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'$this->env->getRuntime('Symfony\Component\Form\FormRenderer')->searchAndRenderBlock(($context["form"]
?? null), 'label', array("label" => "my label"))'
+'$this->env->getRuntime('Symfony\Component\Form\FormRenderer')->searchAndRenderBlock(($context["form"]
?? null), 'label', ["label" => "my label"])'

/tmp/autopkgtest-lxc.p99bggf8/downtmp/build.az6/src/src/Symfony/Bridge/Twig/Tests/Node/SearchAndRenderBlockNodeTest.php:84

4)
Symfony\Bridge\Twig\Tests\Node\SearchAndRenderBlockNodeTest::testCompileLabelWithAttributes
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'$this->env->getRuntime('Symfony\Component\Form\FormRenderer')->searchAndRenderBlock(($context["form"]
?? null), 'label', array("foo" => "bar"))'
+'$this->env->getRuntime('Symfony\Component\Form\FormRenderer')->searchAndRenderBlock(($context["form"]
?? null), 'label', ["foo" => "bar"])'

/tmp/autopkgtest-lxc.p99bggf8/downtmp/build.az6/src/src/Symfony/Bridge/Twig/Tests/Node/SearchAndRenderBlockNodeTest.php:174

5)
Symfony\Bridge\Twig\Tests\Node\SearchAndRenderBlockNodeTest::testCompileLabelWithLabelAndAttributes
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'$this->env->getRuntime('Symfony\Component\Form\FormRenderer')->searchAndRenderBlock(($context["form"]
?? null), 'label', array("foo" => "bar", "label" => "value in argument"))'
+'$this->env->getRuntime('Symfony\Component\Form\FormRenderer')->searchAndRenderBlock(($context["form"]
?? null), 'label', ["foo" => "bar", "label" => "value in argument"])'

/tmp/autopkgtest-lxc.p99bggf8/downtmp/build.az6/src/src/Symfony/Bridge/Twig/Tests/Node/SearchAndRenderBlockNodeTest.php:200

6)
Symfony\Bridge\Twig\Tests\Node\SearchAndRenderBlockNodeTest::testCompileLabelWithLabelThatEvaluatesToNullAndAttributes
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'$this->env->getRuntime('Symfony\Component\Form\FormRenderer')->searchAndRenderBlock(($context["form"]
?? null), 'label', array("foo" => "bar", "label" => "value in
attributes") + (twig_test_empty($_label_ = ((true) ? (null) : (null))) ?
array() : array("label" => $_label_)))'
+'$this->env->getRuntime('Symfony\Component\Form\FormRenderer')->searchAndRenderBlock(($context["form"]
?? null), 'label', ["foo" => "bar", "label" => "value in attributes"] +
(twig_test_empty($_label_ = ((true) ? (null) : (null))) ? array() :
array("label" => $_label_)))'

/tmp/autopkgtest-lxc.p99bggf8/downtmp/build.az6/src/src/Symfony/Bridge/Twig/Tests/Node/SearchAndRenderBlockNodeTest.php:268

7) Symfony\Bridge\Twig\Tests\Node\TransNodeTest::testCompileStrict
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'echo
$this->env->getExtension('Symfony\Bridge\Twig\Extension\TranslationExtension')->getTranslator()->trans("trans
%var%", array_merge(array("%var%" => ($context["var"] ?? null)),
(isset($context["foo"]) || array_key_exists("foo", $context) ?
$context["foo"] : (function () { throw new Twig_Error_Runtime('Variable
"foo" does not exist.', 0, $this->source); })())), "messages");'
+'echo
$this->env->getExtension('Symfony\Bridge\Twig\Extension\TranslationExtension')->getTranslator()->trans("trans
%var%", array_merge(["%var%" => ($context["var"] ?? null)],
(isset($context["foo"]) || array_key_exists("foo", $context) ?
$context["foo"] : (function () { throw new Twig_Error_Runtime('Variable
"foo" does not exist.', 0, $this->source); })())), "messages");'

/tmp/autopkgtest-lxc.p99bggf8/downtmp/build.az6/src/src/Symfony/Bridge/Twig/Tests/Node/TransNodeTest.php:41

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20190119/345e2f96/attachment.sig>