[pkg-php-pear] RFH: PHPUnit 9 compatibility [Was: Bug#976811: transition: php8.0]

[David Prévot]

Hi team,

>> On 11. 12. 2020, at 17:38, David Prévot <taffit at debian.org> wrote: >> Le Tue, Dec 08, 2020 at 09:28:38AM +0100, Ondřej Surý a écrit :
>>> I would like to transition the PHP to version 8.0;
[…]

>> PHPUnit 9
>> is available from experimental, yet uploading to unstable would mean
>> having to deal with dozens of breakage (in the FTBFS form):
>>
>> https://release.debian.org/britney/pseudo-excuses-experimental.html#phpunit

In case the release team accepts Ondřej’s proposal, help fixing 
testsuite for any of the aforementioned packages would be greatly 
appreciated!

Some issues may be already fixed upstream, so if you look into a 
package, you should have a look at the upstream repository first. Most 
of those packaging repositories are actually based on the upstream one. 
Once you have the repository from salsa, you should be able do simply 
update the upstream repository from its URL available on the beginning 
of debian/copyright (and even debian/upstream/metadata if the package 
has been uploaded recently and lintian-brush was run on it). E.g., for 
php-fxsl:

> $ gbp clone git at salsa.debian.org:php-team/pear/php-fxsl
> $ cd php-fxsl/
> $ git remote add upstream $(grep ^Source: debian/copyright | sed 's/Source: //')
> $ git fetch upstream --tags 
> Depuis https://github.com/theseer/fXSL
>  * [nouvelle branche] master        -> upstream/master
>  * [nouvelle branche] release-1.0.2 -> upstream/release-1.0.2
>  * [nouvelle branche] release-1.0.3 -> upstream/release-1.0.3
>  * [nouvelle branche] release-1.0.4 -> upstream/release-1.0.4

If not, someone may already have proposed a fix upstream, so you should 
have a look at the upstream bug tracker. Most upstream are hosted on 
GitHub, so the following should do:

 > $ firefox $(grep ^Source: debian/copyright | sed 's/Source: //')/pulls

If not, you may be on your own.

Once you have a patch ready, please commit it to salsa directly (if it 
doesn’t break the build with PHPUnit 8), or send a merge request or 
submit a bug on the BTS (if the fix is disruptive), but whatever way is 
fine (it’s easy to revert a commit anyway). Bonus if you propose your 
patch upstream!

(TIL that fXSL is dead upstream for six years, yet still used by phpdox 
that still seems maintained).

Please note that this may just be the emerged part of the iceberg: you 
might also have to deal with PHP 8 related issues (so if you manage to 
test things in a PHP 8 environment, that would be best). In case you 
have PHP 8 related fixes, please also act on them as proposed for 
PHPUnit related fixes…

We could add a wiki page to document the usual fixes, and eventually use 
the wiki to coordinate our efforts.

Thanks in advance.

Regards

David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20201211/7ebd8604/attachment.sig>