[pkg-php-pear] RFH: PHPUnit 9 compatibility [Was: Bug#976811: transition: php8.0]

[David Prévot]

Le 14/12/2020 à 11:28, David Prévot a écrit :
> Le 14/12/2020 à 10:00, Marco Villegas a écrit :

>> 1. Fixed packages
>>
>> php-directory-scanner
>> php-doctrine-cache (Not fully fixed? passes on arm64 but not on amd64)
> 
> The logged error is about a network issue (on localhost), maybe just a 
> transient one…
> 
>> php-doctrine-collections
>> php-fdomdocument
>> php-hamcrest
>> php-json-schema
>> php-league-html-to-markdown
>> php-mikey179-vfsstream
>> php-phpdocumentor-type-resolver
>> php-tijsverkoyen-css-to-inline-styles
>> php-webmozart-assert
> 
> There was also:
> 
> jsonlint
> php-codesniffer
> php-composer-spdx-licenses
> php-deepcopy
> php-email-validator
> php-league-commonmark
> php-netscape-bookmark-parser
> php-nikic-fast-route
> php-nyholm-psr7
> php-sabre-vobject
> php-text-password
> php-zeta-console-tools
> php-zeta-base
> pkg-php-tools

I also forgot to mention (Thanks Guilhem! Your last fix does work with 
PHPUnit 9, despite your comment ;):

php-net-ldap2

>> 2. Package git repository contains partial/full fixes
>>
>> pdepend
(PHPUnit 9 fix uploaded, PHP 8.0 issue documented in #977389)
>> php-fxsl
> (PHPUnit 9 fix uploaded, PHP 8.0 issue documented in #977373)
> php-zend-code
> (PHPUnit 9 fix uploaded, PHP 8.0 issue documented in #977376 to #977379)
>> phpmd
(PHPUnit 9 fix uploaded, PHP 8.0 issue documented in #977388)
>> composer
> I’d focus on composer 2 currently available on experimental: it already 
> uses PHPUnit 9, but the autopkgtest needs fixing (help welcome!).
>> php-amqplib
(PHPUnit 9 fix uploaded, PHP 8.0 issue documented in #977396)
>> php-net-ldap2
(gone to list 1, thanks Guilhem!)
>> php-netscape-bookmark-parser
(that one also made it list 1 during the night)
[…]
>> php-oscarotero-gettext
>> php-slim
>> php-text-captcha
> (needs fix in related packages, at least php-text-figlet, for PHP 8 
> compatibility)
I’m about to deal with those last three (upload and/or bug report)
[…]
 >> php-phpseclib
 > (see phpseclib)
(PHPUnit 9 fix uploaded, PHP 8.0 issue documented in #977385)
 >> phpseclib
 > (it’s actually on list 2 ;)
(PHPUnit 9 fix uploaded, PHP 8.0 issue documented in #977384)

>> 3. Pending packages to fix
>>
>> doctrine
> (might already fixed, my last two uploads are unrelated to these issues)
>> php-composer-semver
> (see composer remark above)
>> php-doctrine-dbal
> (could be on list 2: PHPUnit 9 compatibility should be ensured by 
> *removing* the last patch ;).
>> php-imagick
> (something change in PHPT handling, help welcome!)
[…]
>> php-symfony-security-acl
> (help requested upstream):
>      https://github.com/symfony/security-acl/issues/59
>> php-twig
> (could be on list 2: PHPUnit 9 compatibility should be ensured by 
> *removing* the last patch ;).
[…]
> 
> I intend to circle back onto the second list, fixing PHPUnit 9 issue, 
> and documenting the PHP 8.0 one via bug reports. Acting on these bug is 
> welcome for the PHP 8.0 goal.
> 
> I now believe the PHPUnit 9 goal can be reached before the (transition) 
> freeze, among the remaining issues (thank Marco for triaging), I could 
> use some help at least with:
> 
> php-symfony-security-acl, help requested upstream:
>      https://github.com/symfony/security-acl/issues/59)
> 
> composer : I’d focus on composer 2 currently available on experimental: 
> it already uses PHPUnit 9, but the autopkgtest needs fixing

I forgot to restate previously:

php-imagick
(something change in PHPT handling, help welcome!)

Also, as I’m trying to deal promptly with those issues, I haven’t yet 
submitted my patches upstream. Help with that would also be welcome 
(having upstream insight about the proposed fixes is always useful). It 
is not needed in the rare cases I was able to cherry-pick the fix 
upstream (in that case, it’s properly documented in the DEP-3 header, 
nor if upstream code base moved too much from the one available in 
Debian (they may even have a fix already available, but that required 
more work to backport than starting from scratch). In that last case, a 
“Forwarded: not-needed” DEP-3 header should already present on the patch 
(but adding it if I forgot would also be helpful).

In a few hours, within a day top, the list of PHPUnit 9 related issues 
should be up to date with a handful of packages (fingers crossed…).

https://release.debian.org/britney/pseudo-excuses-experimental.html#phpunit

> I’ll come back with more information once I’m done circling back on 
> fixing PHPUnit 9 issues and documenting PHP 8.0 ones.

I guess some help is also needed in the php8.0 transition front 
(documenting issues as done via bugs blocking #976811 and acting on 
them). I don’t know how realistic this transition is really about to 
happen before Bullseye, but at least documenting issues will help the 
release team have a grasp of the work to be done.

https://release.debian.org/britney/pseudo-excuses-experimental.html#php-defaults

Regards

David