[pkg-php-pear] Bug#977400: php-oscarotero-gettext: Not compatible with php8.0

[David Prévot]

Package: php-oscarotero-gettext
Version: 4.8.2-2
Severity: important
Tags: upstream patch
Control: block 976811 by -1

Hi James,

I prepared a trivial ”fix” for the following PHP 8 issue I came across
while preparing a fix about PHPUnit 9:

Gettext\Utils\FunctionsScanner::Gettext\Utils\{closure}(): Argument #1 ($carry) must be passed by reference, value given

https://salsa.debian.org/php-team/pear/php-oscarotero-gettext/-/commit/9651345d5b8bf11fd0e445fe542e43abc5600e7e

Despite this “fix” being actually enough to pass the test suite, it
feels so wrong that I didn’t included it in my last upload. Could you
please have a look at this issue, in a real environment (IIRC, this
package is part of the Shaarli dependency chain) and eventually adopt it
(or remove the patch tag if you confirm it is wrong). As an alternative,
a more recent upstream version may also fix the PHP 8 compatibility
issue (yet the codebase changed so much I didn’t go on the backporting
road for this initial “fix”).

Thanks in advance.

Regards

David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20201214/0fc4d82a/attachment.sig>