[pkg-php-pear] RFH: PHPUnit 9 compatibility [Was: Bug#976811: transition: php8.0]

[David Prévot]

Hi Guilhem,

Le 14/12/2020 à 14:37, Guilhem Moulin a écrit :
> On Mon, 14 Dec 2020 at 14:04:20 -0400, David Prévot wrote:

> Oh oops, wasn't aware of that transition list, should probably
> subscribe to pkg-php-pear at a-l.d.n :-)

You’d be welcome!

>> php-net-ldap2
> 
> Aha good to know, there was a warning “assertInternalType() is
> deprecated and will be removed in PHPUnit 9” in the build log […]

Well, as far as I can tell, you actually handled it as part of part of 
your patch:

-        $this->assertInternalType('string', $ldif->error(true));
-        $this->assertInternalType('int', $ldif->error_lines());
+        $this->assertIsString($ldif->error(true));
+        $this->assertIsInt($ldif->error_lines());

There is still one warning (about PHPUnit 10) that pops up while 
building the package with PHPUnit 9:

1) Net_LDAP2_FilterTest::testCreate
assertRegExp() is deprecated and will be removed in PHPUnit 10. Refactor 
your code to use assertMatchesRegularExpression() instead.

Anyway, with PHPUnit 10 expected to be released in February, I doubt it 
is realistic to get it shipped with Bullseye…

> FWIW as far as php-net-ldap2 is concerned, the package is dead upstream
> […] I guess it would be
> best to document that somewhere in the header of the Debian patch no?

At least a “Forwarded: not needed” should do (while being more verbose 
should help the external reader).

Adding .phpunit.result.cache to debian/clean would help the random 
tester too ;).

Regards

David