[pkg-php-pear] RFS: php-arthurhoaro-web-thumbnailer

James Valleroy jvalleroy at mailbox.org
Wed Jun 3 03:08:41 BST 2020


On 5/27/20 3:30 PM, David Prévot wrote:
> Thank you both. The copyright is not fully documented for
> src/WebThumbnailer/Application/WebAccess/WebAccessCUrl.php (that may be
> a showstopper for the ftp-team, so I didn’t upload the package as is).
> FWIW, I found it with “git grep -i '\(licen\|copy\)'” even before
> noticing it while reviewing the upstream code base.
> 
> Besides that, I only have two additional non mandatory pieces of advice:
>   - you may not need the extra .1 upstream version (+dfsg is explicit
>     enough);
>   - lintian-brush can add the Bug-Submit upstream metadata fields for
>     you.

Hi David,

Thanks for the review. I have push changes to handle each of these points.

Regards,
James

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20200602/197cf4a2/attachment.sig>


More information about the pkg-php-pear mailing list