[pkg-php-pear] Bug#953777: Incorrect fix [Was: php-doctrine-cache_1.10.0-4_source.changes ACCEPTED into unstable]

[Ondřej Surý]

David,

I disagree that all of the added dependencies are wrong. I believe you should declare all the dependencies that the autopkgtest requires and that was not full filled. The autopkgtest needs to at least depend on php-cli.

Also the dependencies are already tight, it’s just that phpX.Y-foo also provides php-foo, so the dependency solver could pick any. But in case you explicitly pull the required package, you should get the real meta-package, and not just the one with provides.

I already filled RoM bug against php7.3, that’s the ultimate fix for all failing autopkgtests, but I think the fixes are correct because they help the dependency solver to pick right package.

Ondřej 
--
Ondřej Surý <ondrej at sury.org>

> On 23 Mar 2020, at 19:33, David Prévot <david at tilapin.org> wrote:
> 
> Hi Ondřej,
> 
> Le 23/03/2020 à 00:53, Debian FTP Masters a écrit :
> […]
>> Source: php-doctrine-cache
> […]
>> Maintainer: Debian PHP PEAR Maintainers <pkg-php-pear at lists.alioth.debian.org>
> […]
>>   * The autopkgtest dependencies were underspecified (Closes: #953777)
> 
> I had a quick look at the fix. It’s useless: phpunit already depend on
> php-cli, php-xml, and php-mbstring.
> 
> https://salsa.debian.org/php-team/pear/php-doctrine-cache/-/commit/77782beaad3a125d97fd1e8541d4c6a1d150b785
> 
> #953777 is about the lack of tight versioning dependency between PHP
> extensions.
> 
> The test log shows a mix of php-7.3 and php-7.4 extensions installed:
> php7.3-mbstring php7.3-sqlite3 php7.3-xml php7.4-cli php7.4-common
> php7.4-json (the autopkgtest is about *partial* upgrade for migrations).
> 
> https://ci.debian.net/data/autopkgtest/testing/amd64/p/php-doctrine-cache/4542910/log.gz
> 
> You may argue that it’s a flow in autopkgtest, but anyway, you can’t fix
> it by adding useless dependencies in a consumer (using php extensions)
> package. You may want to (at least temporarily, since it defeat the main
> purpose of having various PHP versions co-installable) tighten the
> dependencies from php-7.4 (e.g, Breaks: php7.3-mbstring, php-7.3-xml,
> etc.), or try and get an exception from the release team.
> 
> Regards
> 
> David
>