[pkg-php-pear] RFS: php-arthurhoaro-web-thumbnailer

Robin Gustafsson robin at rgson.se
Wed May 20 19:09:34 BST 2020


Hi James,

I cannot sponsor packages, but I have at least had a look at the
packaging and have some comments:

- The "nocheck" condition in override_dh_auto_test is no longer
necessary with debhelper-compat 13.
- The "ln -s" workaround could perhaps be avoided with PHPUnit's
--include-path option.
- I would've expected test preparations (aforementioned workaround and
generating vendor/autoload.php) to be performed in
override_dh_auto_test.
- Upstream's changelog could be installed in override_dh_installchangelogs.
- gbp could be configured to handle the pristine-tar files and to sign its tags.

Regards,
Robin



More information about the pkg-php-pear mailing list