[pkg-php-pear] RFS: php-arthurhoaro-web-thumbnailer

[James Valleroy]

On 5/20/20 2:09 PM, Robin Gustafsson wrote:
> - The "nocheck" condition in override_dh_auto_test is no longer
> necessary with debhelper-compat 13.
> - The "ln -s" workaround could perhaps be avoided with PHPUnit's
> --include-path option.
> - I would've expected test preparations (aforementioned workaround and
> generating vendor/autoload.php) to be performed in
> override_dh_auto_test.
> - Upstream's changelog could be installed in override_dh_installchangelogs.
> - gbp could be configured to handle the pristine-tar files and to sign its tags.

Hi Robin,

Thanks for the review. I have pushed the following changes:
- d/rules: Remove nocheck condition
- d/gbp.conf: Handle pristine-tar and sign tags
- d/rules: Use phpunit's --include-path to avoid workaround

I found that upstream's changelog is actually installed already as changelog.gz.

I kept the test preparations as they are for now.

Regards,
James

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20200521/b84f110c/attachment.sig>