[pkg-php-pear] Sponsor for php-swiftmailer

Robin Gustafsson robin at rgson.se
Fri Nov 20 09:50:38 GMT 2020


Hi Kunal,

Thank you for the review.

> Technically it looks good to me. From a packaging perspective, you'll
> need to include the changelog entry from the 5.4.2-1.1 NMU into
> debian/changelog so that those bugs stay resolved. See [2] for more details.

Done. Thanks for the reference material.

> Minor nits that would be nice if you could fix, but I won't block on:
> * The homepage URL now redirects to <https://swiftmailer.symfony.com/>
> (which notably has HTTPS).
> * The description says "... for PHP 5." You can drop the 5 :)

Fixed those too.

A new version is up on Salsa [1] and mentors [2].

[1]: https://salsa.debian.org/php-team/pear/php-swiftmailer/-/compare/7ee04693...f0b1f9b1
[2]: https://mentors.debian.net/package/libphp-swiftmailer/#upload-2

Regards,
Robin



More information about the pkg-php-pear mailing list