[pkg-php-pear] RFS: php-league-flysystem: FTBFS fix

[Robin Gustafsson]

Hi David,

Thank you for the review and the permissions.

> Thank you. I noticed a few details on the packaging:
> - lintian rightfully notices that Policy has been updated;
> - override_dh_installchangelogs seems useless;
> - please drop me from copyright holders;

Done.

> - you should be able to run the testuite using Internet access on CI
>    with needs-internet to the Restrictions. You could amend your skip
>    patch to set up a group you’d exclude at build time for example.

I've chosen not to, for now at least. It's just one test with one
assertion and I feel like it's not worth the external dependency. I
fear the biggest risk of that test failing would be due to network
issues or when upstream eventually stops hosting the remote file.

> - your patch for #947317 made it to devscripts, you may wish to update
>    README.source (I’m interested to read about it in order simplify my
>    usual workflow ;).

True! Done.

By adding the "gitexport=all" option to debian/watch, the fiddling
with .git/info/attributes will be automatically taken care of when
uscan exports the .orig archive. So with that option set, "uscan" or
even "gbp import-orig --uscan" should produce complete archives
regardless of upstream's .gitattributes settings.

> I notice that you recently dropped debian/salsa-ci.yml since “The
> recommended approach is now to use the centrally maintained config.”
> Where should I find this kind of information? I’d like to enable such CI
> too, and wish to know what data --ci-config-path for salsa(1) is
> expected (I’d rather not use the webUI to set this up for dozens of
> packages) and if I need other things.

I found the new recommendation in the salsa-ci-team/pipeline repo's
readme file [1]:
"If the base pipeline configuration fits your needs without further
modifications,
the recommended way is to use recipes/debian.yml at salsa-ci-team/pipeline as
config path, which refers to a file kept in this repository."

I haven't tried it with the salsa CLI tool, but hopefully that string
would work as-is.

[1] https://salsa.debian.org/salsa-ci-team/pipeline/-/blob/master/README.md#basic-use

Regards,
Robin