[pkg-php-pear] deb packages looking for sponsorship

[Fab Stz]

Hi,

> Welcome in real world where every upstream do it there own way… One way 
> to handle such case could be to copy the src directory into another 
> directory (e.g., “cp -a src real_src”), from there move the testfiles 
> into yet another directory (e.g., “mkdir tests && mv real_src/*Test.php 
> tests/”) and only then, create the {src_real,vendor}/autoload.php files.
> 
> For autopkgtest, using simply “phpab src/*Test.php” should do the trick 
> to create vendor/autoload.php.

Ok these should be updated. Thanks for the guidance.

> >> d/control
> >>
> >> You don’t need pkg-php-tools in Build-Depends (dh-sequence-phpcomposer
> >> is provided by pkg-php-tools since 1.40 IIRC).
> > 
> > 
> > So if one wants to build on stable it would still be needed, right?
> 
> 
> No, pkg-php-tools 1.40 is in stable. If dh-sequence-phpcomposer is not 
> available, it will FTBFS anyway.

Ok, stable has 1.40. But ubuntu focal (20.04?) has 1.38...
Can we leave both pkg-php-tools & dh-sequence-phpcomposer then?

> >> d/copyright
> 
> I’d use the years from the LICENSE file, unless better information 
> exists elsewhere.

Done

> >> d/tests/control
> >>
> >> The purpose of autopkgtest is to test the *installed* package, so you
> >> must not make a League directory and League/Csv symlink: it will force
> >> to use the source (that’s only useful at build time since the package is
> >> not yet built).
> 
> […]
> 
> >> The testsuite requires Internet, so needs-internet should be added to
> >> Restrictions.
> >>
> >>
> >>
> >> Furthermore, buildd do not have Internet access during the build, so the
> >> testsuite must be amended (e.g., filtering away the test or data set
> >> requiring Internet) to run there (at build time, via dh_auto_test):
> > 
> > 
> > So, for autopkgtest, it will use the internet? But if I patch/remove the
> > test, then internet is not needed anymore, so no need to add
> > "needs-internet" ?
> 
> Well, it would be nicer to run the whole testsuite, but your patch won’t 
> allow it.
> 
> 
> > So for buildd which doesn't have the internet we have to remove the test?
> > 
> > For now I created a patch that removes the download of these files.
> 
> 
> Maybe moving the part that needs Internet to a new test, properly 
> setting a new (e.g., internet) group could be excluded (e.g. “phpunit 
> --exclude-group internet”) at build time, while being executed at runtime.
> […]

I'm really not at ease with php unit test. Actually I don't know it. Could we 
leave it that way?

> wrap-and-sort(1) is provided by devscripts, you may wish to run it 
> instead of dealing with this manually (helps to have unified files).

Package should be ready for a new review.

Rgds
Fab