[pkg-php-pear] deb packages looking for sponsorship

[James Valleroy]

Hello Fab,

On 3/20/22 06:48, Fab Stz wrote:
> I uploaded these PHP packages to mentors.debian.net in the last weeks.
> Would someone sponsor them?
> 
> - https://mentors.debian.net/package/php-codeigniter-framework/
> - https://mentors.debian.net/package/php-league-csv/
> - https://mentors.debian.net/package/php-kissifrot-php-ixr/
> - https://mentors.debian.net/package/php-giggsey-locale/
> - https://mentors.debian.net/package/php-giggsey-libphonenumber/
> - https://mentors.debian.net/package/php-datto-json-rpc/
> - https://mentors.debian.net/package/php-datto-json-rpc-http/
> 
> They are all also on https://salsa.debian.org/php-team/pear

Are these libraries required for some end-user application(s) that you 
intend to package? I saw one that mentioned Kalkun, any others?

(In the future, I recommend to always mention this in the ITP. It helps 
to justify why the package should be included in Debian.)

Some other comments from briefly looking through the repositories:

- If the package is not yet in Debian, then IMO don't need to show 
multiple versions in the changelog. For example, 
php-codeigniter-framework can just have 3.1.13-1 as the "Initial 
release", and no other changes need to be listed.

- If there are no patches, then you can just remove the debian/patches/ 
folder completely.

- I noticed there is no pristine-tar branch, is it not used? It seems 
most packages in the team are using pristine-tar.

- If there are tests from upstream, please run them during the package 
build.

- Also please include debian/tests/ autopkgtests if possible. Even a 
trivial test is ok (if marked as Superficial).

I will try to look in more detail later, and give a more thorough review.

--
James
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-php-pear/attachments/20220329/b280c7d3/attachment.sig>