[pkg-php-pear] Bug#1039757: php-arthurhoaro-web-thumbnailer: FTBFS with phpunit 10: TypeError: file_get_contents(): Argument #1 ($filename) must be of type string, bool given

[Athos Ribeiro]

Source: php-arthurhoaro-web-thumbnailer
Version: 2.1.0+dfsg-2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: pkg-php-pear at lists.alioth.debian.org
Usertags: phpunit

Hi,

We will start the phpunit 10 transition in unstable soon. During a test
rebuild, php-arthurhoaro-web-thumbnailer was found to FTBFS.

To reproduce this locally, you need to install the phpunit 10 package (and any
other dependency, which should also be available) from experimental on an
unstable system or build chroot.

Relevant part (hopefully):
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> phpunit --no-coverage --include-path src --testsuite NoNetworkTests
> Sun, 25 Jun 2023 02:58:48 +0000 - Web server started on localhost:8081 with PID 795629
> PHPUnit 10.2.2 by Sebastian Bergmann and contributors.
> 
> Runtime:       PHP 8.2.7
> Configuration: /<<PKGBUILDDIR>>/phpunit.xml.dist
> 
> ...........................SSF..............SSSSS...FFF........  63 / 129 ( 48%)
> .SSSSSSSSSSSSS...................................EESS.EEEE..EE. 126 / 129 ( 97%)
> FSS                                                             129 / 129 (100%)
> 
> Time: 00:00.095, Memory: 10.00 MB
> 
> There was 1 PHPUnit test runner deprecation:
> 
> 1) Your XML configuration validates against a deprecated schema. Migrate your XML configuration using "--migrate-configuration"!
> 
> --
> 
> There were 8 errors:
> 
> 1) WebThumbnailer\WebThumbnailerTest::testDirectImage
> TypeError: file_get_contents(): Argument #1 ($filename) must be of type string, bool given
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:72
> 
> 2) WebThumbnailer\WebThumbnailerTest::testDirectImageWithoutExtension
> TypeError: PHPUnit\Framework\Assert::assertFileEquals(): Argument #2 ($actual) must be of type string, bool given, called in /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php on line 87
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:87
> 
> 3) WebThumbnailer\WebThumbnailerTest::testDownloadDirectImageResizeWidth
> TypeError: PHPUnit\Framework\Assert::assertFileEquals(): Argument #2 ($actual) must be of type string, bool given, called in /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php on line 162
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:162
> 
> 4) WebThumbnailer\WebThumbnailerTest::testDownloadDirectImageResizeHeight
> TypeError: PHPUnit\Framework\Assert::assertFileEquals(): Argument #2 ($actual) must be of type string, bool given, called in /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php on line 177
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:177
> 
> 5) WebThumbnailer\WebThumbnailerTest::testDownloadDirectImageResizeBothWidth
> TypeError: PHPUnit\Framework\Assert::assertFileEquals(): Argument #2 ($actual) must be of type string, bool given, called in /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php on line 192
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:192
> 
> 6) WebThumbnailer\WebThumbnailerTest::testDownloadDirectImageResizeBothHeight
> TypeError: PHPUnit\Framework\Assert::assertFileEquals(): Argument #2 ($actual) must be of type string, bool given, called in /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php on line 207
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:207
> 
> 7) WebThumbnailer\WebThumbnailerTest::testDownloadDirectImageResizeWidthHeightCrop
> TypeError: file_get_contents(): Argument #1 ($filename) must be of type string, bool given
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:254
> 
> 8) WebThumbnailer\WebThumbnailerTest::testDownloadDirectImageResizeWidthHeightCropOverride
> TypeError: file_get_contents(): Argument #1 ($filename) must be of type string, bool given
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:277
> 
> --
> 
> There were 5 failures:
> 
> 1) WebThumbnailer\Finder\DefaultFinderTest::testDefaultFinderImageMimetype
> Failed asserting that false matches expected 'http://localhost:8081/default/image-mimetype.php'.
> 
> /<<PKGBUILDDIR>>/tests/Finder/DefaultFinderTest.php:95
> 
> 2) WebThumbnailer\Finder\QueryRegexFinderTest::testQueryRegexFinderCurlValid
> Failed asserting that false matches expected 'https://domain.tld/pics/thumb.png?name=text'.
> 
> /<<PKGBUILDDIR>>/tests/Finder/QueryRegexFinderTest.php:91
> 
> 3) WebThumbnailer\Finder\QueryRegexFinderTest::testQueryRegexFinderCurlTwoThumbs
> Failed asserting that false matches expected 'https://domain.tld/pics/thumb.png?name=text'.
> 
> /<<PKGBUILDDIR>>/tests/Finder/QueryRegexFinderTest.php:102
> 
> 4) WebThumbnailer\Finder\QueryRegexFinderTest::testQueryRegexFinderCurlWithParameter
> Failed asserting that false matches expected 'https://domain.tld/pics/thumb.png?param=foobar-other'.
> 
> /<<PKGBUILDDIR>>/tests/Finder/QueryRegexFinderTest.php:128
> 
> 5) WebThumbnailer\WebThumbnailerTest::testHotlinkSimpleImageWithoutExtension
> Failed asserting that false matches expected 'http://localhost:8081/default/image'.
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:300
> 
> --
> 
> There were 8 risky tests:
> 
> 1) WebThumbnailer\WebThumbnailerTest::testDirectImage
> This test did not perform any assertions
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:64
> 
> 2) WebThumbnailer\WebThumbnailerTest::testDirectImageWithoutExtension
> This test did not perform any assertions
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:79
> 
> 3) WebThumbnailer\WebThumbnailerTest::testDownloadDirectImageResizeWidth
> This test did not perform any assertions
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:153
> 
> 4) WebThumbnailer\WebThumbnailerTest::testDownloadDirectImageResizeHeight
> This test did not perform any assertions
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:168
> 
> 5) WebThumbnailer\WebThumbnailerTest::testDownloadDirectImageResizeBothWidth
> This test did not perform any assertions
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:183
> 
> 6) WebThumbnailer\WebThumbnailerTest::testDownloadDirectImageResizeBothHeight
> This test did not perform any assertions
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:198
> 
> 7) WebThumbnailer\WebThumbnailerTest::testDownloadDirectImageResizeWidthHeightCrop
> This test did not perform any assertions
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:245
> 
> 8) WebThumbnailer\WebThumbnailerTest::testDownloadDirectImageResizeWidthHeightCropOverride
> This test did not perform any assertions
> 
> /<<PKGBUILDDIR>>/tests/WebThumbnailerTest.php:262
> 
> ERRORS!
> Tests: 129, Assertions: 228, Errors: 8, Failures: 5, Deprecations: 1, Skipped: 24, Risky: 8.
> Sun, 25 Jun 2023 02:58:49 +0000 - Killing process with ID 795629
> make[1]: *** [debian/rules:26: override_dh_auto_test] Error 2


The full build logs and additional context is available at
http://people.ubuntu.com/~athos-ribeiro/rebuilds/phpunit10/0/php-arthurhoaro-web-thumbnailer/

A phpunit reverse-dependencies rebuild status is available at
http://people.ubuntu.com/~athos-ribeiro/rebuilds/phpunit10/index.html

-- 
Athos Ribeiro