[Pkg-postgresql-public] RFS: bucardo

[Nicholas Jefferson]

Hi Peter, thanks for the review.

An updated version of the package is available at:
  http://mentors.debian.net/debian/pool/main/b/bucardo/

> W: bucardo source: out-of-date-standards-version 3.7.2 (current is 3.8.1)
> E: bucardo: dir-or-file-in-var-run var/run/bucardo/
> The init script should perhaps have a Should-Start: postgresql?
> It would be good to use /lib/lsb/init-functions in the init script.
> There is a new section "database" that you should use.
> Add Homepage control field.

Ok, fixed.

> bucardo.postinst and bucardo.postrm don't do anything useful -- remove them.

I've removed bucardo.postrm, and bucardo.postinst now adds a "bucardo"
system user for the daemons.

> bucardo.default appears to be redundant -- if you install the package, the
> daemon should be started.  At least there is no reason given why it shouldn't.

There is no sensible default configuration. bucardo_ctl is invoked with
{port,host,name,user,pass} options to access a configuration database.
These options are now also set in /etc/default/bucardo.

Some local system configuration is specified in that database, for
example: "piddir" (/var/run/bucardo), "reason_file"
(/home/bucardo/restart.reason), "default_email_to" (nobody at example.com),
and "default_email_from" (nobody at example.com). I've added a patch for
/usr/share/doc/bucardo/bucardo.schema to set default values appropriate
for a Debian system.

> Explicitly licensing the Debian packaging of a BSD-licensed package under the
> GPL is bad form and pointless obstructionism in my opinion, especially since
> the packaging is trivial.  Please consider changing that.

Ok, sorry, that was dh_make :-} The packaging is now public domain.

Thanks,

Nicholas