[Pkg-postgresql-public] pg_upgrade support in pg_upgradecluster

[Peter Eisentraut]

I have added pg_upgrade support to pg_upgradecluster.  I have it
basically running, and I would like to discuss some details.

First, invocation interface: I have used -m|--method={dump,copy,link},
where dump is the existing method, and also the default, copy is
pg_upgrade in copy mode, and link is pg_upgrade in link mode.  I'm not
too happy with that, because it obscures that pg_upgrade is being
used, and hides that copy and link are more closely related than dump.
Maybe someone has a better idea.

Scripts in /etc/postgresql-common/pg_upgradecluster.d: I have left it
so that they are used in any of the methods, but I have my doubts
about whether that is appropriate.  I couldn't find any examples of
packages that are actually using this, so it's hard to tell.  Maybe
it's obsolescent?

I have changed the test t/040_upgrade.t to test all three methods, and
they all pass.  I had to skip a number of tests that don't work under
pg_upgrade.

pg_upgradecluster is also used in a number of other tests.  I haven't
taught those about the different upgrade methods, but that could be
done once the interface is settled.

Attached is a patch.  I have minimized the indentation changes for
now.  That would obviously be fixed in the final version.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: deb-pg-common-upgrade.patch
Type: text/x-patch
Size: 10325 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-postgresql-public/attachments/20120724/7f7be40b/attachment.bin>