[Pkg-postgresql-public] test suite problems with pg_stat_tmp

[Christoph Berg]

Re: Peter Eisentraut 2014-09-27 <54263B82.1050605 at debian.org>
> When you run one of the test files manually, e.g.,
> 
>     sudo prove -v t/050_encodings.t

./testsuite t/050_encodings.t

> they now all fail with something like
> 
> not ok 58 - No files in /var/lib/postgresql left behind
> not ok 59 - No files in /var/run/postgresql left behind
> ok 60 - No files in /var/log/postgresql left behind
> # Expected directory contents: [], actual contents: [.psql_history
> .bash_history]
> 
> #   Failed test 'No files in /var/lib/postgresql left behind'
> #   at t/TestLib.pm line 149.

That part hasn't changed, but

> # Expected directory contents: [], actual contents:
> [9.4-ru_RU.UTF-8.pg_stat_tmp 9.4-ru_RU.pg_stat_tmp 9.4-main.pg_stat_tmp]
> 
> #   Failed test 'No files in /var/run/postgresql left behind'
> #   at t/TestLib.pm line 149.

this is something we might want to actually account for in the tests.
stats_temp_directory comes from createcluster.conf, but then the
testsuite masks that by using an empty/different file.

> Apparently, the mounting magic in the testsuite script hides these
> problems, but then it's doubtful whether those test cases would ever
> catch a real problem.

I agree that the tests might be a bit overzealous here, but I couldn't
really say which tests could be removed.

Christoph
-- 
cb at df7cb.de | http://www.df7cb.de/