[Pkg-privacy-commits] [flashproxy] 07/65: clarify some comments

[Ximin Luo]

This is an automated email from the git hooks/post-receive script.

infinity0 pushed a commit to branch _volatile-rc
in repository flashproxy.

commit 82389e0c500544f059ee5656038c780082243ab9
Author: Ximin Luo <infinity0 at gmx.com>
Date:   Tue Jan 7 14:49:42 2014 +0000

    clarify some comments
---
 debian/rules | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/debian/rules b/debian/rules
index 2318edf..456ac0f 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,7 +1,9 @@
 #!/usr/bin/make -f
 
 # NOTE: debian/rules build (which runs tests) must be run outside of fakeroot
-# since the tests open sockets, which fakeroot stubs out.
+# since the tests open sockets, which fakeroot stubs out. In other words, you
+# must run `debian/rules build` separately from `fakeroot debian/rules binary`.
+# (The standard build tools such as dpkg-buildpackage already do this.)
 
 %:
 	dh $@ --with autoreconf,python2
@@ -11,7 +13,8 @@ DH_client = -S makefile -- -f Makefile.client prefix=/usr sysconfdir=/etc
 DH_facilitator = -S autoconf -D facilitator --
 DH_proxy = -S makefile -D proxy/modules/nodejs --
 
-# TODO(infinity0): handle setup.py better
+# TODO(infinity0): handle setup-common.py better; currently we symlink it as a
+# hack. Ideally, we would fix dh_python to support custom setup.py filenames.
 
 override_dh_install:
 	dh_install -XChangeLog -XLICENSE -XMakefile

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-privacy/packages/flashproxy.git