[Pkg-privacy-commits] [torbrowser-launcher] 357/476: Disable the user-download abstraction and corresponding addition, by default.

[Ximin Luo]

This is an automated email from the git hooks/post-receive script.

infinity0 pushed a commit to branch debian
in repository torbrowser-launcher.

commit ea3f680359110f0c091a7719630f676cab06b2fb
Author: intrigeri <intrigeri at boum.org>
Date:   Thu Aug 14 18:03:34 2014 +0000

    Disable the user-download abstraction and corresponding addition, by default.
    
    This partially reverts changes introduced in commit 04b24660, without any
    explanation. Those changes actually allow TBB to read e.g.
    `@{HOME}/[a-zA-Z0-9]*`, that is most of users' personal files, which defeats in
    great part the purpose of this profile. Likewise for read access to `@{HOME}/`,
    which quite often contain folders whose name users might not want to leak.
    
    Still, some people might want to use this, so let's leave these rules in here,
    but commented out, explaining what the consequences of enabling them are.
---
 apparmor/torbrowser.Browser.firefox | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/apparmor/torbrowser.Browser.firefox b/apparmor/torbrowser.Browser.firefox
index af48370..52b2491 100644
--- a/apparmor/torbrowser.Browser.firefox
+++ b/apparmor/torbrowser.Browser.firefox
@@ -3,13 +3,17 @@
 
 /home/*/.local/share/torbrowser/tbb/{i686,x86_64}/tor-browser_*/Browser/firefox {
   #include <abstractions/gnome>
-  #include <abstractions/user-download>
 
   # Comment out the following line if you don't want the Tor Browser
   # to have direct access to your sound hardware. Note that "#include"
   # is *not* a comment, it is valid AppArmor rules syntax.
   #include <abstractions/audio>
 
+  # Uncomment the following lines if you want to give the Tor Browser read-write
+  # access to most of your personal files.
+  # #include <abstractions/user-download>
+  # @{HOME}/ r,
+
   #dbus,
   network tcp,
 
@@ -29,12 +33,6 @@
   @{PROC}/[0-9]*/task/*/stat r,
   @{PROC}/sys/kernel/random/uuid r,
 
-  ## Missing in <abstractions/user-download> #######
-  # Without this line, access is denied to @{HOME},
-  # [dD]ownload{,s}, Desktop... for downloads.
-  @{HOME}/ r,
-  ##################################################
-
   owner @{HOME}/.local/share/torbrowser/tbb/{i686,x86_64}/tor-browser_*/ r,
   owner @{HOME}/.local/share/torbrowser/tbb/{i686,x86_64}/tor-browser_*/* r,
   owner @{HOME}/.local/share/torbrowser/tbb/{i686,x86_64}/tor-browser_*/.** rwk,

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-privacy/packages/torbrowser-launcher.git