[Pkg-privacy-commits] [onionshare] 42/53: Remove all language and localization from download page, to prevent leaking the sender's locale (fixes #228)

Ulrike Uhlig u-guest at moszumanska.debian.org
Wed Dec 30 00:20:15 UTC 2015


This is an automated email from the git hooks/post-receive script.

u-guest pushed a commit to branch debian
in repository onionshare.

commit f2389cc60277d90e47189b05e8b8f83ec4afe131
Author: Micah Lee <micah at micahflee.com>
Date:   Fri Dec 4 12:43:12 2015 -0800

    Remove all language and localization from download page, to prevent leaking the sender's locale (fixes #228)
---
 locale/cs.json        | 3 ---
 locale/de.json        | 3 ---
 locale/en.json        | 3 ---
 locale/eo.json        | 3 ---
 locale/es.json        | 3 ---
 locale/fi.json        | 3 ---
 locale/fr.json        | 3 ---
 locale/nl.json        | 3 ---
 onionshare/index.html | 7 +------
 onionshare/web.py     | 3 +--
 10 files changed, 2 insertions(+), 32 deletions(-)

diff --git a/locale/cs.json b/locale/cs.json
index 5429407..8ac426e 100644
--- a/locale/cs.json
+++ b/locale/cs.json
@@ -10,9 +10,6 @@
     "give_this_url": "Dejte tuto URL osobě, které dané soubory posíláte:",
     "ctrlc_to_stop":  "Stiskněte Ctrl-C pro zastavení serveru",
     "not_a_file": "{0:s} není soubor.",
-    "download_size": "Download size",
-    "filename": "Jméno souboru",
-    "size": "Velikost",
     "download_page_loaded": "Download page loaded",
     "other_page_loaded": "URL loaded",
     "close_on_finish": "Ukončit sdílení automaticky",
diff --git a/locale/de.json b/locale/de.json
index f6f77c4..6960c25 100644
--- a/locale/de.json
+++ b/locale/de.json
@@ -10,9 +10,6 @@
     "give_this_url": "Geben Sie diese URL der Person, der Sie die Datei zusenden möchten:",
     "ctrlc_to_stop":  "Drücken Sie Strg+C um den Server anzuhalten",
     "not_a_file": "{0:s} ist keine Datei.",
-    "download_size": "Dateigrösse",
-    "filename": "Dateiname",
-    "size": "Dateigröße",
     "download_page_loaded": "Seite geladen",
     "other_page_loaded": "URL geladen",
     "close_on_finish": "Den Server automatisch anhalten",
diff --git a/locale/en.json b/locale/en.json
index 819c9b9..b6aa60a 100644
--- a/locale/en.json
+++ b/locale/en.json
@@ -10,9 +10,6 @@
     "give_this_url": "Give this URL to the person you're sending the file to:",
     "ctrlc_to_stop":  "Press Ctrl-C to stop server",
     "not_a_file": "{0:s} is not a file.",
-    "download_size": "Download size",
-    "filename": "Filename",
-    "size": "Size",
     "download_page_loaded": "Download page loaded",
     "other_page_loaded": "URL loaded",
     "close_on_finish": "Stop sharing automatically",
diff --git a/locale/eo.json b/locale/eo.json
index 07cc46e..5970ab9 100644
--- a/locale/eo.json
+++ b/locale/eo.json
@@ -10,9 +10,6 @@
     "give_this_url": "Donu ĉi tiun URL al la persono al kiu vi sendas la dosieron:",
     "ctrlc_to_stop":  "Presu Ctrl-C por halti la servilon",
     "not_a_file": "{0:s} ne estas dosiero.",
-    "download_size": "Elŝuta grandeco",
-    "filename": "Nomo de dosiero",
-    "size": "Grandeco",
     "download_page_loaded": "Download page loaded",
     "other_page_loaded": "URL loaded",
     "close_on_finish": "Halti la kundividadon aŭtomate",
diff --git a/locale/es.json b/locale/es.json
index 8c55725..61f38d2 100644
--- a/locale/es.json
+++ b/locale/es.json
@@ -10,9 +10,6 @@
     "give_this_url": "Entregue esta URL a la persona a la que está enviando el archivo:",
     "ctrlc_to_stop":  "Pulse Ctrl-C para detener el servidor",
     "not_a_file": "{0:s} no es un archivo.",
-    "download_size": "Tamaño de la descarga",
-    "filename": "Archivo",
-    "size": "Tamaño",
     "download_page_loaded": "La página de descarga está lista.",
     "other_page_loaded": "La URL está lista.",
     "close_on_finish": "Apagar el servidor automáticamente.",
diff --git a/locale/fi.json b/locale/fi.json
index f1d937f..cad0ddf 100644
--- a/locale/fi.json
+++ b/locale/fi.json
@@ -10,9 +10,6 @@
     "give_this_url": "Anna tämä URL-osoite henkilölle, jolle lähetät tiedostot:",
     "ctrlc_to_stop":  "Näppäin Ctrl-C pysäyttää palvelimen",
     "not_a_file": "{0:s} Ei ole tiedosto.",
-    "download_size": "Download size",
-    "filename": "Filename",
-    "size": "Size",
     "download_page_loaded": "Lataussivu ladattu",
     "other_page_loaded": "URL-osoite ladattu",
     "close_on_finish": "Pysäytä palvelin automaattisesti",
diff --git a/locale/fr.json b/locale/fr.json
index f154dfb..f286d74 100644
--- a/locale/fr.json
+++ b/locale/fr.json
@@ -9,9 +9,6 @@
     "give_this_url": "Donnez cette URL à la personne qui doit recevoir le fichier :",
     "ctrlc_to_stop":  "Ctrl-C arrête le serveur",
     "not_a_file": "{0:s} n'est pas un fichier.",
-    "download_size": "Taille de téléchargement",
-    "filename": "Nom du fichier",
-    "size": "Taille",
     "download_page_loaded": "Page de téléchargement chargée",
     "other_page_loaded": "URL chargée",
     "close_on_finish": "Arrêter le serveur automatiquement",
diff --git a/locale/nl.json b/locale/nl.json
index a70a0fe..432f4e6 100644
--- a/locale/nl.json
+++ b/locale/nl.json
@@ -10,9 +10,6 @@
     "give_this_url": "Geef deze URL aan de persoon aan wie je dit bestand verzend:",
     "ctrlc_to_stop":  "Druk Ctrl-C om de server te stoppen",
     "not_a_file": "{0:s} is geen bestand.",
-    "download_size": "Downloadgrootte",
-    "filename": "Bestandsnaam",
-    "size": "Grootte",
     "download_page_loaded": "Downloadpagina geladen",
     "other_page_loaded": "URL geladen",
     "close_on_finish": "Stop server automatisch",
diff --git a/onionshare/index.html b/onionshare/index.html
index 7632780..252c628 100644
--- a/onionshare/index.html
+++ b/onionshare/index.html
@@ -77,13 +77,8 @@
   </head>
   <body>
     <p><a class="button" href='/{{ slug }}/download'>{{ filename }} &#x25BC;</a></p>
-    <p class="download-size">{{strings.download_size}}: <strong title="{{ filesize }} bytes">{{ filesize_human }}</strong></p>
+    <p class="download-size"><strong title="{{ filesize }} bytes">{{ filesize_human }}</strong></p>
     <table class="file-list">
-      <tr>
-        <th></th>
-        <th>{{strings.filename}}</th>
-        <th>{{strings.size}}</th>
-      </tr>
       {% for info in file_info.dirs %}
       <tr>
         <td><img width="30" height="30" title="" alt="" src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAB4AAAAeCAYAAAA7MK6iAAAABmJLR0QA/wD/AP+gvaeTAAAACXBIWXMAAA7EAAAOxAGVKw4bAAAAB3RJTUUH3ggbFCQXOpwjbQAAAM5JREFUSMftlksOwyAMRDFCbNjkDL1kz9K75Cq9AZF3kYIM7oqoP/KpcFK1mRUrnsbW2Fbq0N+JiPhZRMS1OZAfzLzocwCAGmC9V2Vhjduarj8CzynGqIwxsDl4SXV267E4uFTN33X8deCxDyV1XXeRYJo1UUDEa9M0pxoRK+b4HiqRcz3nVAJKRK+TSxqaGbrkNKUkBn0oNSK2+T0MA1dau9NzO4QwuvPen1lAxQtEsq/vNpSWhvZ9v/3IRMTWOQezkyuEoKy14tfHoU11A6Mr5Axrp [...]
diff --git a/onionshare/web.py b/onionshare/web.py
index 8706c4d..9e2115d 100644
--- a/onionshare/web.py
+++ b/onionshare/web.py
@@ -147,8 +147,7 @@ def index(slug_candidate):
         file_info=file_info,
         filename=os.path.basename(zip_filename).decode("utf-8"),
         filesize=zip_filesize,
-        filesize_human=helpers.human_readable_filesize(zip_filesize),
-        strings=strings.strings
+        filesize_human=helpers.human_readable_filesize(zip_filesize)
     )
 
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-privacy/packages/onionshare.git



More information about the Pkg-privacy-commits mailing list