[Pkg-privacy-commits] [tails-installer] 33/43: Clarify comments about workarounds.

[Ulrike Uhlig]

This is an automated email from the git hooks/post-receive script.

u-guest pushed a commit to branch debian/sid
in repository tails-installer.

commit b258a969e8ff295ec0d638a0159198cfadede818
Author: intrigeri <intrigeri at boum.org>
Date:   Thu Jul 21 19:03:34 2016 +0000

    Clarify comments about workarounds.
---
 tails_installer/creator.py | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/tails_installer/creator.py b/tails_installer/creator.py
index f3d55a3..2ed77fa 100755
--- a/tails_installer/creator.py
+++ b/tails_installer/creator.py
@@ -874,16 +874,21 @@ class LinuxTailsInstallerCreator(TailsInstallerCreator):
         # XXX: sometimes fails (https://labs.riseup.net/code/issues/10987)
         system_partition.call_set_type_sync(ESP_GUID, GLib.Variant('a{sv}', None))
 
-        # Get a fresh system_partition object
-        # (https://labs.riseup.net/code/issues/10720#note-28)
+        # Get a fresh system_partition object, otherwise
+        # _set_partition_flags sometimes fails with
+        # "GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No
+        # such interface 'org.freedesktop.UDisks2.Partition' on object
+        # at path /org/freedesktop/UDisks2/block_devices/sda1"
         self.rescan_block_device(self._get_object().props.block)
         system_partition = self.first_partition(self.drive['udi'])
 
         # XXX: sometimes fails (https://labs.riseup.net/code/issues/10987)
         self._set_partition_flags(system_partition, SYSTEM_PARTITION_FLAGS)
 
-        # XXX: give the system some more time to recognize the updated partition
-        # (https://labs.riseup.net/code/issues/10720#note-30)
+        # Give the system some more time to recognize the updated
+        # partition, otherwise sometimes later on, when
+        # switch_drive_to_system_partition is called, it calls
+        # _set_drive, that fails with "Cannot find device /dev/sda1".
         self.rescan_block_device(self._get_object().props.block)
 
     def update_system_partition_properties(self):

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-privacy/packages/tails-installer.git