[Pkg-privacy-commits] [txtorcon] 03/08: Disable broken test in GeoIP module

Iain R. Learmonth irl at moszumanska.debian.org
Sat Sep 16 03:54:55 UTC 2017


This is an automated email from the git hooks/post-receive script.

irl pushed a commit to branch master
in repository txtorcon.

commit 30566b38b1b95683bddcd2fad4b3721e33e96db8
Author: Iain R. Learmonth <irl at debian.org>
Date:   Mon Sep 11 12:15:55 2017 +0100

    Disable broken test in GeoIP module
---
 .../patches/disable_test_for_invalid_geoip.patch   | 32 ++++++++++++++++++++++
 debian/patches/series                              |  1 +
 2 files changed, 33 insertions(+)

diff --git a/debian/patches/disable_test_for_invalid_geoip.patch b/debian/patches/disable_test_for_invalid_geoip.patch
new file mode 100644
index 0000000..04f4c8b
--- /dev/null
+++ b/debian/patches/disable_test_for_invalid_geoip.patch
@@ -0,0 +1,32 @@
+Description: Disable a broken test for GeoIP
+ The test is meant to check to see that a GeoIP object can be created, but
+ is currently broken as there a new checks in the GeoIP library that ensure
+ that a valid database is used, which this test doesn't use.
+Author: Iain R. Learmonth <irl at debian.org>
+Bug: https://github.com/meejah/txtorcon/issues/250
+Last-Update: 2017-09-11
+---
+
+--- a/test/test_util.py
++++ b/test/test_util.py
+@@ -67,13 +67,13 @@
+         util.GeoIP = _GeoIP
+         self.assertEqual(ret_val, None)
+ 
+-    @skipIf('pypy' in sys.version.lower(), "No GeoIP in PyPy")
+-    def test_return_geoip_object(self):
+-        from txtorcon import util
+-        (fd, f) = tempfile.mkstemp()
+-        ret_val = util.create_geoip(f)
+-        delete_file_or_tree(f)
+-        self.assertEqual(type(ret_val).__name__, 'GeoIP')
++#    @skipIf('pypy' in sys.version.lower(), "No GeoIP in PyPy")
++#    def test_return_geoip_object(self):
++#        from txtorcon import util
++#        (fd, f) = tempfile.mkstemp()
++#        ret_val = util.create_geoip(f)
++#        delete_file_or_tree(f)
++#        self.assertEqual(type(ret_val).__name__, 'GeoIP')
+ 
+ 
+ class TestFindKeywords(unittest.TestCase):
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..eb8a892
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+disable_test_for_invalid_geoip.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-privacy/packages/txtorcon.git



More information about the Pkg-privacy-commits mailing list