[Pkg-privacy-commits] [Git][pkg-privacy-team/torbrowser-launcher][debian/stretch-backports] 103 commits: Update AppArmor comments

Roger Shimizu rosh at debian.org
Tue Nov 6 15:31:31 GMT 2018


Roger Shimizu pushed to branch debian/stretch-backports at Privacy Maintainers / torbrowser-launcher


Commits:
835bfc59 by Micah Lee at 2018-01-28T19:19:20Z
Update AppArmor comments

- - - - -
064ad1f7 by intrigeri at 2018-01-29T08:24:13Z
Drop spurious trailing whitespace.

- - - - -
cdb290fe by intrigeri at 2018-01-29T08:24:13Z
AppArmor: allow plugin-container to read file/app association information.

We already allow the main browser profile to do that but with e10s
plugin-container now needs it as well.

- - - - -
9c609476 by intrigeri at 2018-01-29T08:24:13Z
AppArmor: allow Firefox to ptrace plugin-container and to send it term signals.

With e10s Firefox does not need to ptrace itself anymore but instead it needs
to ptrace and kill its child plugin-container processes.

- - - - -
d62a692a by intrigeri at 2018-01-29T08:24:13Z
AppArmor: allow plugin-container to receive term signals from the parent Firefox process.

We already allow Firefox to send term signals to plugin-container;
this is the receiving counterpart.

This requires giving the Firefox profile a proper name (torbrowser_firefox)
because this:

  signal (receive) set=("term") peer=/home/*/.local/share/torbrowser/tbb/{i686,x86_64}/tor-browser_*/Browser/firefox

… does not work.

Note to package maintainers
===========================

(This should probably be copied to the release notes.)

Due to the profile renaming, upgrading the
/etc/apparmor.d/torbrowser.Browser.firefox file requires special care. The best
option is probably to strongly recommend users to reboot their system after
this upgrade.

Other options I can think of have unacceptable consequences:

 - if we unload the old profile from the kernel, we will leave any already
   running Tor Browser's Firefox executable unconfined, which is an unacceptable
   violation of the user's security expectations;

 - if we don't unload the old profile from the kernel, surprising behaviour will
   happen such as:

    - any already running Tor Browser's Firefox executable will be left confined
      under the old profile which won't play well with new rules that have
      peer=torbrowser_firefox;
    - unpredictable behavior when a new Tor Browser is started, because two
      profiles matching the Tor Browser's Firefox executable are loaded.

- - - - -
f4093174 by intrigeri at 2018-01-29T08:24:13Z
Fix comment.

- - - - -
936aee55 by intrigeri at 2018-01-29T08:24:13Z
AppArmor: allow Firefox to fully manage its fontconfig cache.

So far we allowed it to do everything in there except a link operation, so let's
be consistent.

- - - - -
dedd45b0 by intrigeri at 2018-01-29T08:24:13Z
AppArmor: grant access to mostly innocuous stuff plugin-container tries to read.

Same rationale as commit 68f502c3fbb754742cd23967cf30038ff6ce799a.

- - - - -
27289e19 by intrigeri at 2018-01-29T08:24:13Z
AppArmor: silence denial logs about PulseAudio.

We don't currently allow access to the audio subsystem; let's not let AppArmor
spam the logs about it.

- - - - -
0109e95e by intrigeri at 2018-01-29T08:24:13Z
AppArmor: silence more inherited files access denial.

- - - - -
b1e082fe by intrigeri at 2018-01-29T08:24:13Z
AppArmor: drop support for long-obsolete paths.

- - - - -
a9bef63b by intrigeri at 2018-01-29T08:24:13Z
AppArmor: refactor thanks to variables defined in tunables/torbrowser.

- - - - -
33fd86fa by intrigeri at 2018-01-29T08:24:13Z
AppArmor: give the tor profile a stable name.

This will allow us to handle upgrades more nicely in the future,
e.g. when the executable path changes. Besides, this makes the output of
aa-status and logs much easier to grasp.

Note to packagers: exactly as for the similar change applied to the Tor
Browser's Firefox profile, please consider recommending users to reboot their
system after the upgrade that applies this change.

- - - - -
850d5606 by intrigeri at 2018-01-29T08:24:13Z
AppArmor: support some of the included pluggable transports.

This fixes support for obfs4 and obfs3.

meek and fte require vastly more extended permissions and thus dedicated
child profiles.

- - - - -
91652b64 by intrigeri at 2018-01-29T08:24:52Z
AppArmor: remove boilerplate from local override files.

This matches how recent dh-apparmor behaves.

- - - - -
acc967dc by Laurent Forthomme at 2018-01-30T20:04:45Z
Update fr.po

Updated the French translation!
- - - - -
d0a5cc45 by Micah Lee at 2018-02-27T05:22:42Z
Add github code ownders

- - - - -
0e9db70e by Micah Lee at 2018-03-19T08:37:04Z
Add @intrigeri as code owner for AppArmor profiles

- - - - -
f8a4f746 by Micah Lee at 2018-03-19T16:29:12Z
Port Settings from gtk2 to Qt5, and also switch from python2 to python3

- - - - -
052a0995 by Micah Lee at 2018-03-22T18:00:22Z
Removed modem sound :(

- - - - -
3c187ecf by Micah Lee at 2018-03-22T18:22:22Z
Add icons to settings buttons

- - - - -
f7cc20d6 by Micah Lee at 2018-03-22T21:21:23Z
Refactor Launcher to use Qt5, removing all of gtk2 (does not execute yet still because of twisted issues)

- - - - -
39fd6a05 by Micah Lee at 2018-03-22T21:35:25Z
Replace twisted with requests. Downloads work, but does not handle errors or update the GUI

- - - - -
490844f4 by Micah Lee at 2018-03-22T22:10:37Z
Download in a separate thread, using requests

- - - - -
3a793303 by Micah Lee at 2018-03-22T22:18:46Z
Fix buttons, and actually delete download path on exit

- - - - -
7054fb0e by Micah Lee at 2018-03-23T02:46:41Z
Start making basic download error handling work again, and remove old twisted code

- - - - -
a23056bd by Micah Lee at 2018-03-23T03:23:21Z
Verify signature in a separate thread

- - - - -
6a54e329 by Micah Lee at 2018-03-23T03:33:55Z
Extract tarball in a separate thread

- - - - -
1d3b1078 by Micah Lee at 2018-03-23T03:52:54Z
Check for SSL error when downloading

- - - - -
ca0027cd by Micah Lee at 2018-03-23T19:40:19Z
Fix issue with settings checkboxes not working correctly

- - - - -
0195e489 by Micah Lee at 2018-03-23T19:49:52Z
Make downloading over Tor work

- - - - -
055a26ca by Micah Lee at 2018-03-23T19:56:32Z
Give more intelligence errors if connection error while using socks proxy

- - - - -
f1473aae by Micah Lee at 2018-03-23T20:00:10Z
Fix ampersand

- - - - -
2b854d43 by Micah Lee at 2018-03-23T20:13:52Z
Fix style on setup.py

- - - - -
467fd098 by Micah Lee at 2018-03-23T20:20:06Z
Update build scripts and dependencies

- - - - -
df33b473 by Micah Lee at 2018-03-23T20:36:37Z
Fix flake8 style issues

- - - - -
45e6c016 by Micah Lee at 2018-03-23T20:40:44Z
Allow ctrl-c to work again (see https://stackoverflow.com/questions/5160577/ctrl-c-doesnt-work-with-pyqt)

- - - - -
a7f16695 by Micah Lee at 2018-03-23T20:45:33Z
Only try refreshing the keyring when necessary

- - - - -
b8453e35 by Micah Lee at 2018-03-23T21:43:08Z
Must retain a reference to the QMainWindow, or Qt never shows it

- - - - -
7cc2611e by Micah Lee at 2018-03-23T21:50:12Z
Center the window

- - - - -
826efbec by Micah Lee at 2018-03-23T22:42:11Z
Fixed various issues related to sig verification. Now if the verification fails, it saves a backup. And it uses gpg2 to refresh the keyring instead of gpg1, which did nothing.

- - - - -
23f9d6d5 by Micah Lee at 2018-03-23T22:43:03Z
Add gnupg2 as a dependency

- - - - -
dff21a7f by Micah Lee at 2018-03-23T22:47:37Z
Clean up dependencies, and remove requirements.txt because it is out-of-date and I use systemwide packages for deps

- - - - -
bc0ffbd0 by Micah Lee at 2018-03-23T22:55:23Z
Updated translations

- - - - -
14233d0a by Micah Lee at 2018-03-23T23:11:51Z
Tweak build files to fix issues in debian building

- - - - -
feb5830b by Micah Lee at 2018-03-24T21:54:29Z
Merge branch 'patch-1' of https://github.com/forthommel/torbrowser-launcher into forthommel-patch-1

- - - - -
f97b550b by Micah Lee at 2018-03-24T22:05:22Z
Merge branch 'forthommel-patch-1' into major-refactor

- - - - -
2f8b8dda by Micah Lee at 2018-03-26T18:32:16Z
Version bump to 0.3.0.dev

- - - - -
8301c4db by Roger Shimizu at 2018-03-27T13:20:20Z
Merge remote-tracking branch 'micahflee/develop'

- - - - -
83c04dd5 by Roger Shimizu at 2018-03-27T13:24:52Z
d/patches: Rebase patches

- - - - -
aac63a10 by Roger Shimizu at 2018-03-27T15:15:54Z
Support new release 0.3.0.dev in develop branch

debian/control:
- Update Build-Depends list to python3 series.
- Update Depends list to match current python3 implementation.
- Move debian/source.lintian-overrides
  to debian/source/lintian-overrides to comfort lintian.

debian/rules:
- Use pybuild as buildsystem to avoid pyversions command error.

- - - - -
419e5f78 by Roger Shimizu at 2018-03-28T11:07:29Z
d/patches: Add patch 0017 and 0018 to fix the extra dialog issue

- - - - -
f780a58c by Roger Shimizu at 2018-03-28T11:15:20Z
Prepare to release 0.3.0~dev-1~exp1 to experimental

- - - - -
bbd173e0 by Roger Shimizu at 2018-03-28T12:46:30Z
Prepare to release 0.3.0~dev-1~exp2 to experimental

d/rules: Skip the test since it fails under python 3.6

- - - - -
8a762563 by intrigeri at 2018-04-06T07:05:37Z
Merge pull request #310 from intrigeri/apparmor-201801-edition

AppArmor profiles, 2018-01 edition
- - - - -
61eb4b2e by Roger Shimizu at 2018-06-24T17:18:42Z
Merge branch 'debian/sid' into debian/experimental

- - - - -
d231496f by Roger Shimizu at 2018-06-24T17:24:05Z
Prepare to release 0.3.0~dev-1~exp3 to experimental

* Merge debian/sid branch to incorporate latest changes.
* debian/control:
  - Amend Vcs-* a bit to specify debian/sid branch as default.

- - - - -
ad95bbda by intrigeri at 2018-07-03T15:43:10Z
AppArmor: allow Firefox to read /usr/share/glib-2.0/schemas/gschemas.compiled.

Otherwise, Tor Browser 8.0a9 crashes when clicking "Save Page As".

- - - - -
35d08323 by Kunitsyn Andrey Sergeevich at 2018-07-07T17:31:38Z
Update the Russian translate

- - - - -
4e4bbd67 by Carl Joseph Hirner III at 2018-07-29T19:40:21Z
Delete launcher.py
- - - - -
bd9e67c2 by Carl Joseph Hirner III at 2018-07-29T19:40:46Z
Add files via upload
- - - - -
a67f026c by intrigeri at 2018-08-18T19:23:13Z
AppArmor: adjust Firefox binary path for Tor Browser 8.0a10.

At this point it seems unlikely that the develop branch will be released
before Tor Browser 8.0 so here we go, let's get ready.

Note that I could have written firefox{,.real} instead, to support both Tor
Browser 7.5 and 8.0, but then we would have to open the profile more broadly so
the new shell wrapper installed as "firefox" by Tor Browser 8.0a10 can do its
job. This does not seem worth the hassle and will be fine as long as this new
torbrowser-launcher is released approximately at the same time as, or after, Tor
Browser 8.

- - - - -
678d0834 by intrigeri at 2018-09-10T07:55:55Z
AppArmor: confine Firefox 60 "Web Content" processes under the torbrowser_plugin_container AppArmor profile.

- - - - -
45265423 by intrigeri at 2018-09-10T07:55:59Z
AppArmor: give Tor Browser's Web Content process some more innocuous access it now needs.

- - - - -
eb328f2a by intrigeri at 2018-09-10T09:41:49Z
AppArmor: give Web Content processes read access to the startup cache, otherwise they fail to load

- - - - -
b828bdfa by Micah Lee at 2018-09-14T22:00:41Z
Properly detect the system's locale

- - - - -
e886c201 by Micah Lee at 2018-09-14T22:04:55Z
Update list of languages that Tor Browser is available in

- - - - -
1eee4dcd by Micah Lee at 2018-09-14T22:09:45Z
Merge branch 'develop' of https://github.com/deskos-xp/torbrowser-launcher into deskos-xp-develop

- - - - -
e6069cfe by Micah Lee at 2018-09-14T22:11:33Z
Remove extra print statement

- - - - -
db2e3c9a by Micah Lee at 2018-09-14T22:11:41Z
Merge branch 'deskos-xp-develop' into develop

- - - - -
11dd4d00 by Micah Lee at 2018-09-14T22:14:25Z
Merge branch 'develop' of https://github.com/NaruTrey/torbrowser-launcher into NaruTrey-develop

- - - - -
e9b7eab1 by Micah Lee at 2018-09-14T22:14:32Z
Merge branch 'NaruTrey-develop' into develop

- - - - -
b50706b7 by Micah Lee at 2018-09-14T22:32:13Z
Merge branch 'locale-fix' into develop

- - - - -
d6d01588 by Micah Lee at 2018-09-14T22:33:04Z
Version bump to 0.3.0 and updated changelog

- - - - -
79a191dc by Micah Lee at 2018-09-14T22:55:33Z
Make ppa script use python3, and switch the default suite to bionic

- - - - -
69eb6cde by Micah Lee at 2018-09-14T23:16:30Z
Add all the dependencies as build dependencies, to get the ppa to build

- - - - -
491be97f by Roger Shimizu at 2018-09-18T13:12:14Z
d/patches: Refresh patches and Cherry-pick 5 upstream patches

5 upstream patches to fix appamor profile for Tor Browser 8.0

- - - - -
51cb120e by Ulrike Uhlig at 2018-09-18T13:13:31Z
Remove myself from uploaders.

(cherry picked from commit 5648d7d884cc20066684c59bb0d93f031d3d8a49)

- - - - -
9abf5bbb by Roger Shimizu at 2018-09-18T13:18:41Z
Make lintian slightly happy

* debian/control:
  - Rename tag X-Python-Version to XS-Python-Version.

(cherry picked from commit 8b15bbd4b7fa3533842c41feec8044622c1a6f14)

- - - - -
1686f018 by Roger Shimizu at 2018-09-18T13:39:31Z
d/torbrowser-launcher.maintscript: rm_conffile appamor profile

rm_conffile appamor profile /etc/apparmor.d/local/*, which was
removed since 0.2.9-2. Thanks to gregor herrmann for the fix.

(cherry picked from commit d0deb2f923edbaf3c2801c46d74b7925c5605593)

- - - - -
eaa5cfc0 by Roger Shimizu at 2018-09-18T13:39:31Z
d/control: Add XB-Python-Version tag for binary package

(cherry picked from commit e20c71d8da0a82578573a55a72bb0f2cf7d3dadf)

- - - - -
9943a063 by Roger Shimizu at 2018-09-18T13:42:14Z
d/control: Remove branch info from Vcs-Git, which is already default

- - - - -
d7e0b6a8 by Roger Shimizu at 2018-09-18T13:42:28Z
Prepare to release 0.3.0~dev-1~exp4

- - - - -
e92689e8 by Roger Shimizu at 2018-09-18T14:17:50Z
Merge branch 'debian/sid' into debian/experimental

- - - - -
78b2fb37 by Roger Shimizu at 2018-09-18T14:22:05Z
Merge tag 'v0.3.0' into debian/experimental

Version 0.3.0

- - - - -
6fb3fc08 by Roger Shimizu at 2018-09-18T14:47:05Z
New upstream release 0.3.0 and refresh d/patches

Upstreamed patches are removed.

- - - - -
4c1f9370 by Roger Shimizu at 2018-09-19T13:52:17Z
d/control: Remove XS-Python-Version and XB-Python-Version

Since lintian says it's not necessary.

- - - - -
04d9921f by Roger Shimizu at 2018-09-19T14:06:56Z
Prepare to release 0.3.0-1~exp1

- - - - -
3c47a30e by Micah Lee at 2018-09-27T18:09:14Z
Fix SHARE so that it works to run without installing

- - - - -
e57f1a22 by Micah Lee at 2018-09-27T18:32:10Z
Actually hide TBL window

- - - - -
15336310 by Micah Lee at 2018-09-28T00:13:38Z
Update Tor Browser Developers public key

- - - - -
21c4442d by Roger Shimizu at 2018-09-29T04:23:43Z
Rebuild as 0.2.9-6~bpo8+1 for jessie-backports-sloppy

- - - - -
bc9347e9 by Roger Shimizu at 2018-09-30T01:16:13Z
d/copyright: Add comment section to explain why this is contrib package

(cherry picked from commit 75c9e6ba05f4d310fd0bf9afca6b5085d8653d29)

- - - - -
15640980 by Roger Shimizu at 2018-09-30T01:18:40Z
d/patches: Cherry-pick upstream patch to update Tor Browser Developers public key

(cherry picked from commit 6f7a64236a451281624b2a2d83a98c0d1151eef1)

- - - - -
cf38af83 by Roger Shimizu at 2018-09-30T01:20:22Z
Prepare to release 0.3.0-1~exp2

- - - - -
f3c066ad by Micah Lee at 2018-10-25T17:27:46Z
Bump version to 0.3.1 and update changelog

- - - - -
b0f91a26 by Roger Shimizu at 2018-10-27T16:46:46Z
Merge tag 'v0.3.1' into debian/experimental

Version 0.3.1

- - - - -
4ec65d9c by Roger Shimizu at 2018-10-27T16:53:57Z
New upstream release 0.3.1 and remove upstreamed 0004 patch

- - - - -
b724de3b by Roger Shimizu at 2018-10-27T17:27:31Z
Prepare to release 0.3.1-1~exp1 to experimental

- - - - -
ab21c934 by Roger Shimizu at 2018-10-31T15:45:41Z
Merge branch 'debian/experimental' into debian/sid

- - - - -
a7fbc931 by Roger Shimizu at 2018-10-31T15:48:04Z
Prepare to release 0.3.1-1

- - - - -
fd8a6332 by Roger Shimizu at 2018-11-06T13:29:59Z
Merge branch 'debian/sid' into debian/stretch-backports

- - - - -
4b8f917c by Roger Shimizu at 2018-11-06T13:31:07Z
Rebuild as 0.3.1-1~bpo9+1 for stretch-backports

- - - - -


30 changed files:

- + .github/CODEOWNERS
- BUILD.md
- CHANGELOG.md
- apparmor/local/torbrowser.Browser.firefox
- apparmor/local/torbrowser.Browser.plugin-container
- apparmor/local/torbrowser.Tor.tor
- apparmor/torbrowser.Browser.firefox
- apparmor/torbrowser.Browser.plugin-container
- apparmor/torbrowser.Tor.tor
- build_deb.sh
- build_rpm.sh
- debian/changelog
- debian/control
- debian/patches/0016-Remove-apparmor-local-path-from-setup.py.patch → debian/patches/0001-Remove-apparmor-local-path-from-setup.py.patch
- − debian/patches/0001-Update-AppArmor-comments.patch
- − debian/patches/0002-Drop-spurious-trailing-whitespace.patch
- + debian/patches/0002-show-gui-only-if-tbb-not-installed.patch
- − debian/patches/0003-AppArmor-allow-plugin-container-to-read-file-app-ass.patch
- + debian/patches/0003-remove-double-common-assignment.patch
- − debian/patches/0004-AppArmor-allow-Firefox-to-ptrace-plugin-container-an.patch
- − debian/patches/0005-AppArmor-allow-plugin-container-to-receive-term-sign.patch
- − debian/patches/0006-Fix-comment.patch
- − debian/patches/0007-AppArmor-allow-Firefox-to-fully-manage-its-fontconfi.patch
- − debian/patches/0008-AppArmor-grant-access-to-mostly-innocuous-stuff-plug.patch
- − debian/patches/0009-AppArmor-silence-denial-logs-about-PulseAudio.patch
- − debian/patches/0010-AppArmor-silence-more-inherited-files-access-denial.patch
- − debian/patches/0011-AppArmor-drop-support-for-long-obsolete-paths.patch
- − debian/patches/0012-AppArmor-refactor-thanks-to-variables-defined-in-tun.patch
- − debian/patches/0013-AppArmor-give-the-tor-profile-a-stable-name.patch
- − debian/patches/0014-AppArmor-support-some-of-the-included-pluggable-tran.patch


The diff was not included because it is too large.


View it on GitLab: https://salsa.debian.org/pkg-privacy-team/torbrowser-launcher/compare/6b2e5a80bf12269f6b40c83cc8b85f1ea73da8c6...4b8f917c9eee939c0002fe5632029da86d364e88

-- 
View it on GitLab: https://salsa.debian.org/pkg-privacy-team/torbrowser-launcher/compare/6b2e5a80bf12269f6b40c83cc8b85f1ea73da8c6...4b8f917c9eee939c0002fe5632029da86d364e88
You're receiving this email because of your account on salsa.debian.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-privacy-commits/attachments/20181106/88e7358e/attachment-0001.html>


More information about the Pkg-privacy-commits mailing list