[Pkg-privacy-commits] [Git][pkg-privacy-team/monkeysphere][master] Revert "Avoid TIOCSTI abuse by the monkeysphere user"

[Daniel Kahn Gillmor]

Daniel Kahn Gillmor pushed to branch master at Privacy Maintainers / monkeysphere


Commits:
ecba7302 by Daniel Kahn Gillmor at 2019-05-13T04:33:15Z
Revert "Avoid TIOCSTI abuse by the monkeysphere user"

This reverts commit 97ade311fc287985972bb73a47dd75450260c389.

With this changeset, we find that "monkeysphere setup" hangs
indefinitely as the superuser -- runuser --pty doesn't terminate as it
should when its child process exits, so this isn't an appropriate
change to try to ship.

- - - - -


1 changed file:

- src/share/common


Changes:

=====================================
src/share/common
=====================================
@@ -110,12 +110,8 @@ run_as_monkeysphere_user() {
 
          # if root, run command as monkeysphere user
 	'root')
-            local -a runuser_args=(--user "$MONKEYSPHERE_USER")
-            if runuser --help | grep -q -- --pty; then
-                runuser_args+=(--pty)
-            fi
             # requote arguments using bash builtin feature (see "help printf"):
-	    runuser "${runuser_args[@]}" -- "$@"
+	    runuser -u "$MONKEYSPHERE_USER" -- "$@"
 	    ;;
 
 	# otherwise, fail



View it on GitLab: https://salsa.debian.org/pkg-privacy-team/monkeysphere/commit/ecba7302b56383bea1a4283b990310d889844ed2

-- 
View it on GitLab: https://salsa.debian.org/pkg-privacy-team/monkeysphere/commit/ecba7302b56383bea1a4283b990310d889844ed2
You're receiving this email because of your account on salsa.debian.org.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-privacy-commits/attachments/20190513/2e889e59/attachment.html>