[Pkg-privacy-maintainers] Bug#908463: Bug#908463: torbrowser-launcher: Fails to start "Web Content" processes due to outdated AppArmor policy

[gregor herrmann]

On Sat, 15 Sep 2018 11:01:39 +0900, Roger Shimizu wrote:

> > After upgrading to 0.2.9-4, adequate complains:
> >
> > torbrowser-launcher: obsolete-conffile /etc/apparmor.d/local/torbrowser.Tor.tor
> > torbrowser-launcher: obsolete-conffile /etc/apparmor.d/local/torbrowser.Browser.plugin-container
> > torbrowser-launcher: obsolete-conffile /etc/apparmor.d/local/torbrowser.Browser.firefox
> 
> Sorry, I don't have these errors when upgrading package.
> 
> ====
> # dpkg -i torbrowser-launcher_0.2.9-4_amd64.deb
> (Reading database ... 272719 files and directories currently installed.)
> Preparing to unpack torbrowser-launcher_0.2.9-4_amd64.deb ...
> Unpacking torbrowser-launcher (0.2.9-4) over (0.2.9-3) ...
> Setting up torbrowser-launcher (0.2.9-4) ...
> Installing new version of config file
> /etc/apparmor.d/torbrowser.Browser.firefox ...
> Processing triggers for desktop-file-utils (0.23-1) ...
> Processing triggers for mime-support (3.60) ...
> Processing triggers for man-db (2.7.6.1-2) ...
> ====
> 
> > After getting rid of them, I have a starting torbrowser again.
> >
> > Looks like some dpkg-maintscript-helper(1) magic is needed here ...
> 
> Could you provide an example, or even patch?
> Thanks!

After looking at the package/repo:

The files under /etc/apparmor.d/local were created in 0.2.9-1 (with
the upstream import) and were removed in 0.2.9-2, probably with
0016-Remove-apparmor-local-path-from-setup.py.patch. Or maybe with
debian/patches/0015-AppArmor-remove-boilerplate-from-local-override-file.patch.
Or with both :)

This is somewhat confusing but 0.2.9-1 seems to be the only release
with

drwxr-xr-x root/root         0 2018-01-29 15:17 ./etc/apparmor.d/local/
-rw-r--r-- root/root       134 2018-01-28 19:33 ./etc/apparmor.d/local/torbrowser.Browser.firefox
-rw-r--r-- root/root       133 2018-01-28 19:33 ./etc/apparmor.d/local/torbrowser.Browser.plugin-container
-rw-r--r-- root/root       133 2018-01-28 19:33 ./etc/apparmor.d/local/torbrowser.Tor.tor

(That also means that adequate must have warned me earlier?)

Anyway, these conffiles are not shipped any more; either that's a
mistake or they need to be properly removed.

There is already debian/torbrowser-launcher.maintscript which IMO
needs three new lines:

rm_conffile /etc/apparmor.d/local/torbrowser.Tor.tor 0.2.9-2~ torbrowser-launcher
rm_conffile /etc/apparmor.d/local/torbrowser.Browser.plugin-container 0.2.9-2~ torbrowser-launcher
rm_conffile /etc/apparmor.d/local/torbrowser.Browser.firefox 0.2.9-2~ torbrowser-launcher

Or maybe s/0.2.9-2~/0.2.9-5~/ , if I'm reading dpkg-maintscript-helper(1)
correctly.

HTH,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Peter Jones: Hooked onto your love
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-privacy-maintainers/attachments/20180915/60eee3e4/attachment.sig>