[Pkg-privacy-maintainers] Bug#753173: the locale bug is back

[gregor herrmann]

On Wed, 17 Feb 2016 17:08:08 +0100, gregor herrmann wrote:

> I can confirm that this works for my locale settings as well.
> Nice :)

And the bug is back with 0.3.1-1:

With this locale settings ...

% locale
LANG=
LANGUAGE=
LC_CTYPE=de_AT.utf8
LC_NUMERIC="POSIX"
LC_TIME="POSIX"
LC_COLLATE="POSIX"
LC_MONETARY="POSIX"
LC_MESSAGES="POSIX"
LC_PAPER="POSIX"
LC_NAME="POSIX"
LC_ADDRESS="POSIX"
LC_TELEPHONE="POSIX"
LC_MEASUREMENT="POSIX"
LC_IDENTIFICATION="POSIX"
LC_ALL=

... the German tarball is downloaded ...

% torbrowser-launcher 
Tor Browser Launcher
By Micah Lee, licensed under MIT
version 0.3.1
https://github.com/micahflee/torbrowser-launcher
Creating GnuPG homedir /home/gregoa/.local/share/torbrowser/gnupg_homedir
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/home/gregoa/tmp/runtime-gregoa'
Downloading Tor Browser for the first time.
Downloading https://aus1.torproject.org/torbrowser/update_3/release/Linux_x86_64-gcc3/x/en-US
Latest version: 8.0.3
Downloading https://dist.torproject.org/torbrowser/8.0.3/tor-browser-linux64-8.0.3_de.tar.xz.asc
Downloading https://dist.torproject.org/torbrowser/8.0.3/tor-browser-linux64-8.0.3_de.tar.xz
Verifying Signature
Extracting tor-browser-linux64-8.0.3_de.tar.xz
Running /home/gregoa/.local/share/torbrowser/tbb/x86_64/tor-browser_de/start-tor-browser.desktop
Launching './Browser/start-tor-browser --detach'...

... and the configuration dialog is in German, and torbrowser itself
as well.


And the fix seems to be the same one as last time:

#v+
--- /usr/lib/python3/dist-packages/torbrowser_launcher/common.py~	2018-10-25 19:27:46.000000000 +0200
+++ /usr/lib/python3/dist-packages/torbrowser_launcher/common.py	2018-11-01 14:48:21.363114182 +0100
@@ -73,7 +73,7 @@
 
         # figure out the language
         available_languages = ['ar', 'ca', 'da', 'de', 'en-US', 'es-ES', 'fa', 'fr', 'ga-IE', 'he', 'id', 'is', 'it', 'ja', 'ko', 'nb-NO', 'nl', 'pl', 'pt-BR', 'ru', 'sv-SE', 'tr', 'vi', 'zh-CN', 'zh-TW']
-        default_locale = locale.getlocale()[0]
+        default_locale = locale.getlocale(locale.LC_MESSAGES)[0]
         if default_locale is None:
             self.language = 'en-US'
         else:
#v-


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: The Doors: People are Strange
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-privacy-maintainers/attachments/20181101/9a45220e/attachment.sig>