[Pkg-privacy-maintainers] Bug#971299: Bug#971299: onionshare: Switch to python3-pycryptodome

[Clément Hermann]

Hi,

On 10/01/2021 23:46, Sebastian Ramacher wrote:
> On 2020-10-05 15:18:46 +0200, Clément Hermann wrote:
>>
>> Hi,
>>
>> Control: block 971299 with 886291
>> thanks
>>
>> On 28/09/2020 23:29, Sebastian Ramacher wrote:
>>> Source: onionshare
>>> Version: 2.2-2
>>> Severity: important
>>> Tags: sid bullseye
>>> Usertags: pycrypto
>>>
>>> Dear maintainer,
>>>
>>> onionshare currently Build-Depends or Depends on python3-crypto from
>>> PyCrypto. This project is no longer maintained and PyCryptodome
>>> (https://www.pycryptodome.org/en/latest/) provides a drop in
>>> replacement. Please switch to python3-pycryptodome. I'd like to
>>> remove python-crypto before the release of bullseye.
>>
>>
>> As far as I understand it, pycryptodome *can* be a drop-in replacement
>> usually, but not currently in Debian since it doesn't install in Crypto
>> but Cryptodomex namespace (#886291).
>>
>> Are there any plan to change it when python3-crypto is removed or before ?
>>
>> Of course, we can patch onionshare to import cryptodomex, but that patch
>> would be debian-only then… Upstream already expect pycryptodome as
>> Crypto module.
> 
> Sorry for the delay. I don't have any plans other than removing
> python3-crypto. CCing the pycryptodome maintainer for more input.

Thanks. Meanwhile, Ulrike added a patch to import cryptodome explicitly,
and I just uploaded the version with it. It's a short-term fix IMO,
until #886291 is clarified, but at least it removes the dep to pycrypto.

Cheers,

-- 
nodens