[Pkg-privacy-maintainers] Bug#1009420: libotr: FTBFS: client.c:624:30: error: ‘PF_UNIX’ undeclared (first use in this function)

[Lucas Nussbaum]

Source: libotr
Version: 4.1.1-4
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20220412 ftbfs-bookworm

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I. -I../../..   -Wdate-time -D_FORTIFY_SOURCE=2 -I../../../include -I../../../src -I../../../tests/utils/ -I.  -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -fstack-protector-all -Wstack-protector -fwrapv -fno-strict-overflow -Wall -Wextra -Wno-unused-parameter -Wformat-security --param ssp-buffer-size=1 -fPIE -c -o client.o client.c
> client.c: In function ‘ops_inject_msg’:
> client.c:151:15: warning: implicit declaration of function ‘send’ [-Wimplicit-function-declaration]
>   151 |         ret = send(oinfo->sock, &msg, sizeof(msg), 0);
>       |               ^~~~
> client.c: In function ‘recv_otr_msg’:
> client.c:553:15: warning: implicit declaration of function ‘recv’ [-Wimplicit-function-declaration]
>   553 |         ret = recv(sock, &omsg, sizeof(omsg), 0);
>       |               ^~~~
> client.c: In function ‘alice_thread’:
> client.c:624:23: warning: implicit declaration of function ‘socket’ [-Wimplicit-function-declaration]
>   624 |         sock_to_bob = socket(PF_UNIX, SOCK_STREAM, 0);
>       |                       ^~~~~~
> client.c:624:30: error: ‘PF_UNIX’ undeclared (first use in this function)
>   624 |         sock_to_bob = socket(PF_UNIX, SOCK_STREAM, 0);
>       |                              ^~~~~~~
> client.c:624:30: note: each undeclared identifier is reported only once for each function it appears in
> client.c:624:39: error: ‘SOCK_STREAM’ undeclared (first use in this function)
>   624 |         sock_to_bob = socket(PF_UNIX, SOCK_STREAM, 0);
>       |                                       ^~~~~~~~~~~
> client.c:638:15: warning: implicit declaration of function ‘connect’ [-Wimplicit-function-declaration]
>   638 |         ret = connect(sock_to_bob, (struct sockaddr *) &bob_sun,
>       |               ^~~~~~~
> client.c:725:57: warning: implicit declaration of function ‘accept’; did you mean ‘acct’? [-Wimplicit-function-declaration]
>   725 |                                         sock_from_bob = accept(fd, (struct sockaddr *) &sun,
>       |                                                         ^~~~~~
>       |                                                         acct
> client.c: In function ‘bob_thread’:
> client.c:776:32: error: ‘PF_UNIX’ undeclared (first use in this function)
>   776 |         sock_to_alice = socket(PF_UNIX, SOCK_STREAM, 0);
>       |                                ^~~~~~~
> client.c:776:41: error: ‘SOCK_STREAM’ undeclared (first use in this function)
>   776 |         sock_to_alice = socket(PF_UNIX, SOCK_STREAM, 0);
>       |                                         ^~~~~~~~~~~
> client.c: In function ‘create_unix_socket’:
> client.c:979:28: error: ‘PF_UNIX’ undeclared (first use in this function)
>   979 |         if ((sock = socket(PF_UNIX, SOCK_STREAM, 0)) < 0) {
>       |                            ^~~~~~~
> client.c:979:37: error: ‘SOCK_STREAM’ undeclared (first use in this function)
>   979 |         if ((sock = socket(PF_UNIX, SOCK_STREAM, 0)) < 0) {
>       |                                     ^~~~~~~~~~~
> client.c:986:27: error: ‘AF_UNIX’ undeclared (first use in this function)
>   986 |         sun->sun_family = AF_UNIX;
>       |                           ^~~~~~~
> client.c:990:15: warning: implicit declaration of function ‘bind’ [-Wimplicit-function-declaration]
>   990 |         ret = bind(sock, (struct sockaddr *) sun, sizeof(struct sockaddr_un));
>       |               ^~~~
> client.c:996:15: warning: implicit declaration of function ‘listen’ [-Wimplicit-function-declaration]
>   996 |         ret = listen(sock, 10);
>       |               ^~~~~~
> make[5]: *** [Makefile:375: client.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2022/04/12/libotr_4.1.1-4_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220412;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220412&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.