[Pkg-privacy-maintainers] Bug#1010441: torbrowser-launcher fails to download browser bundle when launched for the first time

[Paul Garret]

Package: torbrowser-launcher
Version: 0.3.5-2
Severity: important
X-Debbugs-Cc: psgt at cock.li

Dear Maintainer,

Current version of torbrowser-launcher in Sid fails to download tor browser 
when launched for the first time (ie when ~/.local/share/torbrowser/tbb/ does 
not exist) with the following error:

Tor Browser Launcher
By Micah Lee, licensed under MIT
version 0.3.5
https://github.com/micahflee/torbrowser-launcher
Downloading Tor Browser for the first time.
Downloading https://aus1.torproject.org/torbrowser/update_3/release/Linux_x86_64-gcc3/x/en-US
Traceback (most recent call last):
  File "/usr/bin/torbrowser-launcher", line 30, in <module>
    torbrowser_launcher.main()
  File "/usr/lib/python3/dist-packages/torbrowser_launcher/__init__.py", line 98, in main
    gui.move(
TypeError: arguments did not match any overloaded call:
  move(self, QPoint): argument 1 has unexpected type 'float'
  move(self, int, int): argument 1 has unexpected type 'float'


Changing both arguments to int works to the following workaround may be
used:

--- /usr/lib/python3/dist-packages/torbrowser_launcher/__init__.py.orig	2022-05-01 17:44:35.369210869 +0200
+++ /usr/lib/python3/dist-packages/torbrowser_launcher/__init__.py	2022-05-01 17:45:16.697352319 +0200
@@ -96,8 +96,8 @@
             desktop = app.desktop()
             window_size = gui.size()
             gui.move(
-                (desktop.width() - window_size.width()) / 2,
-                (desktop.height() - window_size.height()) / 2
+                int((desktop.width() - window_size.width()) / 2),
+                int((desktop.height() - window_size.height()) / 2)
             )
             gui.show()
             sys.exit(app.exec_())




-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.17.0-1-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=ca_ES.UTF-8, LC_CTYPE=ca_ES.UTF-8 (charmap=UTF-8), LANGUAGE=ca:en_US
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages torbrowser-launcher depends on:
ii  ca-certificates    20211016
ii  gnupg              2.2.35-2
ii  libdbus-glib-1-2   0.112-2
ii  python3            3.10.4-1
ii  python3-gpg        1.16.0-1.2
ii  python3-packaging  21.3-1
ii  python3-pyqt5      5.15.6+dfsg-1+b2
ii  python3-requests   2.27.1+dfsg-1
ii  python3-socks      1.7.1+dfsg-1

Versions of packages torbrowser-launcher recommends:
ii  tor  0.4.7.7-1

Versions of packages torbrowser-launcher suggests:
ii  apparmor  3.0.4-2

-- no debconf information