[Pkg-privacy-maintainers] Bug#1023568: flask-socketio is outdated, leading to broken autopkgtest in onionshare

[Carsten Schoenert]

Hi,

Am 12.11.22 um 17:15 schrieb Hefee:
> Hey,
> 
> can you give me a link to the complete output of the autopkgtests to check what
> is broken.

sure.

https://people.debian.org/~tijuca/build+autopkgtest_onionshare_2.5-2_amd64.build.gz

Looking a second time with a deeper view on it, there is something more 
under the hood to tune and adjust.

E.g.
> autopkgtest [06:29:12]: test share_website: mkdir "$AUTOPKGTEST_TMP/website"; XDG_CONFIG_HOME="$AUTOPKGTEST_TMP" onionshare-cli --local-only --website "$AUTOPKGTEST_TMP/website" --auto-stop-timer 2
> autopkgtest [06:29:12]: test share_website: [-----------------------
> ╭───────────────────────────────────────────╮
> │    *            ▄▄█████▄▄            *    │
> │               ▄████▀▀▀████▄     *         │
> │              ▀▀█▀       ▀██▄              │
> │      *      ▄█▄          ▀██▄             │
> │           ▄█████▄         ███        -+-  │
> │             ███         ▀█████▀           │
> │             ▀██▄          ▀█▀             │
> │         *    ▀██▄       ▄█▄▄     *        │
> │ *             ▀████▄▄▄████▀               │
> │                 ▀▀█████▀▀                 │
> │             -+-                     *     │
> │   ▄▀▄               ▄▀▀ █                 │
> │   █ █     ▀         ▀▄  █                 │
> │   █ █ █▀▄ █ ▄▀▄ █▀▄  ▀▄ █▀▄ ▄▀▄ █▄▀ ▄█▄   │
> │   ▀▄▀ █ █ █ ▀▄▀ █ █ ▄▄▀ █ █ ▀▄█ █   ▀▄▄   │
> │                                           │
> │                   v2.5                    │
> │                                           │
> │          https://onionshare.org/          │
> ╰───────────────────────────────────────────╯
> 
> Exception in thread Thread-2 (start):
> Traceback (most recent call last):
>   File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
>     self.run()
>   File "/usr/lib/python3.10/threading.py", line 953, in run
>     self._target(*self._args, **self._kwargs)
>   File "/usr/lib/python3/dist-packages/onionshare_cli/web/web.py", line 375, in start
>     self.app.run(host=host, port=port, threaded=True)
>   File "/usr/lib/python3/dist-packages/flask/app.py", line 1183, in run
>     cli.show_server_banner(self.debug, self.name)
> TypeError: stubbed_show_server_banner() missing 2 required positional arguments: 'app_import_path' and 'eager_loading'
> 
> Give this address and private key to the recipient:
> http://127.0.0.1:17632
> Private key: E2GOT5LTUTP3OAMRCRXO4GSH6VKJEUOXZQUC336SRKAHTTT5OVSA
> 
> Press Ctrl+C to stop the server
> autopkgtest [06:29:12]: test share_website: -----------------------]
> autopkgtest [06:29:12]: test share_website:  - - - - - - - - - - results - - - - - - - - - -
> share_website        PASS



> Actually his test is the only one that tests the GUI application
> onionshare ( I don't know any good way to check GUI applications). In it self
> it only test does not check any feature of onionshare (that's why it is marked
> as  superficial) - But segfaulting when you just want to view the help means
> properly that there is an issue with the application by itself.

Of course, that's why we do quite the same for Thunderbird. Also we 
would see potential under linking.

-- 
Regrads
Carsten