[Pkg-privacy-maintainers] Bug#1025508: onionprobe: config and examples installed to unusual locations

[Stefano Rivera]

Source: onionprobe
Version: 1.0.0+ds-2.1
Severity: normal

The next upload of dh-python will change the layout of onionprobe's
installed data:

$ debdiff existing/onionprobe_1.0.0+ds-2.1_all.deb new/onionprobe_1.0.0+ds-2.1_all.deb
[The following lists of changes regard files as different if they have
different names, permissions or owners.]

Files in second .deb but not in first
-------------------------------------
-rw-r--r--  root/root   /usr/onionprobe/configs/real-world-onion-sites.yaml
-rw-r--r--  root/root   /usr/onionprobe/configs/securedrop.yaml
-rw-r--r--  root/root   /usr/onionprobe/configs/tor.yaml
-rwxr-xr-x  root/root   /usr/onionprobe/examples/real-world-onion-sites.py
-rwxr-xr-x  root/root   /usr/onionprobe/examples/securedrop.py
-rwxr-xr-x  root/root   /usr/onionprobe/examples/tpo.py

Files in first .deb but not in second
-------------------------------------
-rw-r--r--  root/root   /usr/lib/python3/dist-packages/onionprobe/configs/real-world-onion-sites.yaml
-rw-r--r--  root/root   /usr/lib/python3/dist-packages/onionprobe/configs/securedrop.yaml
-rw-r--r--  root/root   /usr/lib/python3/dist-packages/onionprobe/configs/tor.yaml
-rwxr-xr-x  root/root   /usr/lib/python3/dist-packages/onionprobe/examples/real-world-onion-sites.py
-rwxr-xr-x  root/root   /usr/lib/python3/dist-packages/onionprobe/examples/securedrop.py
-rwxr-xr-x  root/root   /usr/lib/python3/dist-packages/onionprobe/examples/tpo.py

Control files: lines which differ (wdiff format)
------------------------------------------------
Installed-Size: [-263-] {+264+}

This is due to the fix for #1025485.

Neither of these looks quite correct. /usr/onionprobe would be against
the FHS.

If the package expects to find configs and examples within its module,
then this change will break it, and you'll probably need to patch the
setup.cfg or manually move the files around.

If it doesn't, then they should probably be moved to /etc/ and
/usr/share/doc/onionprobe/.

SR