[Pkg-privacy-maintainers] Bug#1091943: onionshare: FTBFS: E ModuleNotFoundError: No module named 'colorama'

[Santiago Vila]

Package: src:onionshare
Version: 2.6.2-4
Severity: serious
Tags: ftbfs trixie sid

Dear maintainer:

During a rebuild of all packages in unstable, your package failed to build:

Note: Similar failures in: androguard onionshare sqlfluff

--------------------------------------------------------------------------------
[...]
 debian/rules clean
dh clean --buildsystem=pybuild
   debian/rules override_dh_auto_clean
make[1]: Entering directory '/<<PKGBUILDDIR>>'
PYBUILD_NAME=onionshare-cli dh_auto_clean --buildsystem=pybuild --sourcedirectory cli
	pybuild --clean -i python{version} -p 3.12 --dir cli
	rm -rf .pybuild/
	find . -name \*.pyc -exec rm {} \;
PYBUILD_NAME=onionshare dh_auto_clean --buildsystem=pybuild --sourcedirectory desktop
	pybuild --clean -i python{version} -p 3.12 --dir desktop
	rm -rf .pybuild/
	find . -name \*.pyc -exec rm {} \;
find . -type d -name '*.egg-info' -exec rm -rvf {} \+
find . -type d -name '.pytest_cache' -exec rm -rvf {} \+
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_autoreconf_clean -O--buildsystem=pybuild
   dh_clean -O--buildsystem=pybuild
	rm -f debian/debhelper-build-stamp
	rm -rf debian/.debhelper/
	rm -f -- debian/onionshare.substvars debian/onionshare-cli.substvars debian/files
	rm -fr -- debian/onionshare/ debian/tmp/ debian/onionshare-cli/
	find .  \( \( \
		\( -path .\*/.git -o -path .\*/.svn -o -path .\*/.bzr -o -path .\*/.hg -o -path .\*/CVS -o -path .\*/.pc -o -path .\*/_darcs \) -prune -o -type f -a \
	        \( -name '#*#' -o -name '.*~' -o -name '*~' -o -name DEADJOE \
		 -o -name '*.orig' -o -name '*.rej' -o -name '*.bak' \
		 -o -name '.*.orig' -o -name .*.rej -o -name '.SUMS' \
		 -o -name TAGS -o \( -path '*/.deps/*' -a -name '*.P' \) \
		\) -exec rm -f {} + \) -o \
		\( -type d -a \( -name autom4te.cache -o -name __pycache__ \) -prune -exec rm -rf {} + \) \)
 debian/rules binary
dh binary --buildsystem=pybuild
   dh_update_autotools_config -O--buildsystem=pybuild
   dh_autoreconf -O--buildsystem=pybuild
   debian/rules override_dh_auto_configure
make[1]: Entering directory '/<<PKGBUILDDIR>>'
PYBUILD_NAME=onionshare-cli dh_auto_configure --buildsystem=pybuild --sourcedirectory cli
	pybuild --configure -i python{version} -p 3.12 --dir cli
PYBUILD_NAME=onionshare dh_auto_configure --buildsystem=pybuild --sourcedirectory desktop
	pybuild --configure -i python{version} -p 3.12 --dir desktop
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
	rm -f debian/onionshare-cli.debhelper.log debian/onionshare.debhelper.log
   debian/rules override_dh_auto_build
make[1]: Entering directory '/<<PKGBUILDDIR>>'
PYBUILD_NAME=onionshare-cli dh_auto_build --buildsystem=pybuild --sourcedirectory cli --\
    --after-build "CURDIR=/<<PKGBUILDDIR>> BUILD_DIR={build_dir} /<<PKGBUILDDIR>>/debian/missing-sources/uglifyjs.sh"
	pybuild --build -i python{version} -p 3.12 --after-build "CURDIR=/<<PKGBUILDDIR>> BUILD_DIR={build_dir} /<<PKGBUILDDIR>>/debian/missing-sources/uglifyjs.sh" --dir cli
I: pybuild plugin_pyproject:129: Building wheel for python3.12 with "build" module
I: pybuild base:311: python3.12 -m build --skip-dependency-check --no-isolation --wheel --outdir /<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onionshare-cli  
* Building wheel...
Successfully built onionshare_cli-2.6.2-py3-none-any.whl
I: pybuild plugin_pyproject:144: Unpacking wheel built for python3.12 with "installer" module
I: pybuild pybuild:334: CURDIR=/<<PKGBUILDDIR>> BUILD_DIR=/<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onionshare-cli/build /<<PKGBUILDDIR>>/debian/missing-sources/uglifyjs.sh
+ uglifyjs --compress --mangle -o /<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onionshare-cli/build/onionshare_cli/resources/static/js/socket.io.min.js -- /<<PKGBUILDDIR>>/debian/missing-sources/socket.io.js
+ uglifyjs --compress --mangle -o /<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onionshare-cli/build/onionshare_cli/resources/static/js/jquery-3.5.1.min.js -- /<<PKGBUILDDIR>>/debian/missing-sources/jquery-3.5.1.js
PYBUILD_NAME=onionshare dh_auto_build --buildsystem=pybuild --sourcedirectory desktop
	pybuild --build -i python{version} -p 3.12 --dir desktop
I: pybuild plugin_pyproject:129: Building wheel for python3.12 with "build" module
I: pybuild base:311: python3.12 -m build --skip-dependency-check --no-isolation --wheel --outdir /<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onionshare  
* Building wheel...
Successfully built onionshare-2.6.2-py3-none-any.whl
I: pybuild plugin_pyproject:144: Unpacking wheel built for python3.12 with "installer" module
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
	rm -f debian/onionshare-cli.debhelper.log debian/onionshare.debhelper.log
   debian/rules override_dh_auto_test
make[1]: Entering directory '/<<PKGBUILDDIR>>'
PYBUILD_NAME=onionshare-cli HOME=/tmp dh_auto_test --buildsystem=pybuild --sourcedirectory cli
	pybuild --test --test-pytest -i python{version} -p 3.12 --dir cli
I: pybuild base:311: cd /<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onionshare-cli/build; python3.12 -m pytest tests
ImportError while loading conftest '/<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onionshare-cli/build/tests/conftest.py'.
tests/conftest.py:8: in <module>
    from onionshare_cli import common, web
onionshare_cli/__init__.py:29: in <module>
    from .common import Common, CannotFindTor
onionshare_cli/common.py:34: in <module>
    import colorama
E   ModuleNotFoundError: No module named 'colorama'
E: pybuild pybuild:389: test: plugin pyproject failed with: exit code=4: cd /<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_onionshare-cli/build; python3.12 -m pytest tests
	rm -fr -- /tmp/dh-xdg-rundir-Z8ZTvHYH
dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p 3.12 --dir cli returned exit code 13
make[1]: *** [debian/rules:50: override_dh_auto_test] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:5: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------

The above is just how the build ends and not necessarily the most relevant part.
If required, the full build log is available here:

https://people.debian.org/~sanvila/build-logs/202501/

About the archive rebuild: The build was made on virtual machines from AWS,
using sbuild and a reduced chroot with only build-essential packages.

If you could not reproduce the bug please contact me privately, as I
am willing to provide ssh access to a virtual machine where the bug is
fully reproducible.

If this is really a bug in one of the build-depends, please use
reassign and add an affects on src:onionshare, so that this is still
visible in the BTS web page for this package.

Thanks.