[Pkg-privacy-maintainers] Request for review for patch in torsocks

[Hefee]

Hey,

I finally made torsocks ready to work in Multi-Arch, I added a patch for 
torsocks, that makes that possible, with the help of Helmut and the initial 
author Yuriy.

But as the patch disables a "safety" check. That's why I want others to look 
at the patch [1] for torsocks. My rationale here is: I think it is fine to 
disable the check.

[1] https://salsa.debian.org/pkg-privacy-team/torsocks/-/blob/master/debian/
patches/0004-Make-torsocks-multi-arch-foreign-compatible.patch

The issue I see is this:
If arch from executable and the corresponding libtorsocks is not installed, 
only a Error is printed, but still the executable is executed without routing 
trough tor. The disabled check in torsocks somehow would catch this, if we 
knew the arch of the executable in advanced correctly. Or if we can make sure, 
that LD_PRELOAD would stop executing.

e.g. I install libtorsocks:amd64 and wget:i386 I get:
$wget -O- -4 icanhazip.com
XX.230.187.XX
$ torsocks wget -O- -4 icanhazip.com
ERROR: ld.so: object 'libtorsocks.so' from LD_PRELOAD cannot be preloaded 
(cannot open shared object file): ignored.
[...]
XX.230.187.XX
[...]

(installing libtorsocks:i386 fixes this)

On the other side, this does not got worse; currently torsocks just will print 
a different error see #902792 (installing libtorsocks:i386 does not fix this 
issue; you also need to call /usr/bin/i386-linux-gnu-torsocks). So you see 
there is a improvement, users do not need to select the torsocks arch specific 
shell script.

Best regards,

hefee
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-privacy-maintainers/attachments/20250307/b945dfa4/attachment.sig>