[Pkg-privacy-maintainers] torbirdy 0.1.4

[intrigeri]

Hi,

I had a look, and I've pushed a few small improvements to the
debian/sid branch.

May you please push your "upstream" branch? It seems outdated in
Vcs-Git.

May you please improve a bit the "Patch Torbirdy's default locale."
entry in debian/changelog? It doesn't make it clear what problem is
solved, nor how.

Other than that, it looks good, thanks! Once these small issues are
fixed I'm happy to test and upload, but still, please read on :)


There were 4 different packaging methods documented in d/README.source
already, and now we have 5. Wow. Of course it's not your (U's) duty to
fix that situation. Still, note that commit daf8289 will break those,
among the documented workflows, that use upstream's Git tag instead of
their XPI; this commit is essentially reverting Lunar's e14bdc7, that
I think he did so that he could use his preferred workflow. So the
revert "war" has already started, and next time someone wants to use
a Git-tag-without-XPI workflow, they'll need to revert the revert.
That's not a blocker for this upload, but I suggest you folks discuss
this topic and find out a way that works for everybody who's working
on this package :)

Other than that, here are some comments on the packaging (nothing in
there is news ⇒ no regression ⇒ not blockers):

* Years are outdated in debian/copyright. That's something one needs
  to check every time we import a new upstream release. Not a blocker
  but I would appreciate if it was fixed in this upload.

* I find it a bit sad to not ship the upstream ChangeLog, but that's
  not news and I don't care that much.

* There's some noise in both Debian patches' header.

Cheers,
-- 
intrigeri