[Pkg-privacy-maintainers] MAT 0.6 packaging

intrigeri intrigeri at debian.org
Mon Jan 11 15:04:34 UTC 2016


Hi,

I had a closer look, and uploaded the package! :)

I hadn't noticed that you had *moved* the test suite run to
autopkgtest. I can see that it's an optimization when preparing a new
package (one doesn't have to run the test suite twice), but I'm not
sure I really like this change. IMO, build-time tests and autopkgtests
serve slightly different purposes, e.g. one can't assume all uploaders
will run the autopkgtests prior to upload, and with this change, the
full archive rebuilds done by QA people would not run the test suite
anymore. So, I'd like to keep running the test suite via
override_dh_auto_test too, done in commit d400b30 for the 0.6.1
upload, but of course you may disagree and we can discuss it if
needed :)

The autopkgtest fail for me (I'm using the QEMU backend, didn't try
LXC):

  test-installed       FAIL stderr: test_remove (clitest.TestRemovecli)

Maybe it's fine and we should tell the autopkgtest that the test suite
is expected to send stuff to STDERR? (I don't think it's a blocker, so
I'll upload as-is so we'll see if it passes on debci).

As some other team-members can confirm, I have a serious problem with
spurious trailing whitespace at EOL, and I can't help insisting that
it should not exist. I've removed some newly introduced ones with
commit 7478985. It would make my life simpler if you configured your
Git environment to notice such things more easily :)

Thanks again,
cheers,
-- 
intrigeri



More information about the Pkg-privacy-maintainers mailing list