[Pkg-privacy-maintainers] Bug#812115: helo_argument IP should be encapsulated in []'s

[Chris Knadle]

Package: xul-ext-torbirdy
Version: 0.1.4-1
Severity: normal
Tags: patch

Torbirdy sets mail.smtpserver.default.hello_argument = "127.0.0.1" which is
nonconformant with RFC 5821 §4.1.3:

   https://tools.ietf.org/html/rfc5321#section-4.1.3

I'm attaching a patch which fixes this.

The issue that this is causing is that I have mail servers I run close
connections that use raw IP addresses in the HELO/EHLO, and that happens
prior to any SMTP AUTH.  I was having to reset this setting on every Icedove
startup until I found where it was being set.

Thanks

  -- Chris

-- 
Chris Knadle
Chris.Knadle at coredump.us
-------------- next part --------------
Description: IP addresses in HELO/EHLO greetings should be
 encapsulated in brackets [] to conform with RFC 5821 §4.1.3:
 https://tools.ietf.org/html/rfc5321#section-4.1.3
Author: Christopher Knadle <Chris.Knadle at coredump.us>
Last-Updated: 2016-01-20

--- a/components/torbirdy.js
+++ b/components/torbirdy.js
@@ -166,7 +166,7 @@
   */
 
   // Prevent hostname leaks.
-  "mail.smtpserver.default.hello_argument": "127.0.0.1",
+  "mail.smtpserver.default.hello_argument": "[127.0.0.1]",
   // Compose messages in plain text (by default).
   "mail.html_compose": false,
   "mail.identity.default.compose_html": false,