[Pkg-privacy-maintainers] Bug#812115: Bug#812115: helo_argument IP should be encapsulated in []'s

[u]

Hi,

Chris Knadle:
> u:
>> Hi Chris,
> 
> Hey, u.  ;-)
> 
>> Chris Knadle:
>>> Package: xul-ext-torbirdy
>>> Version: 0.1.4-1
>>> Severity: normal
>>> Tags: patch
>>>
>>> Torbirdy sets mail.smtpserver.default.hello_argument = "127.0.0.1" which is
>>> nonconformant with RFC 5821 §4.1.3:
>>>
>>>    https://tools.ietf.org/html/rfc5321#section-4.1.3
>>>
>>> I'm attaching a patch which fixes this.
>>>
>>> The issue that this is causing is that I have mail servers I run close
>>> connections that use raw IP addresses in the HELO/EHLO, and that happens
>>> prior to any SMTP AUTH.  I was having to reset this setting on every Icedove
>>> startup until I found where it was being set.
>>
>> thank you very much.
>>
>> I'll forward this bug & patch upstream. I think it belongs there
> 
> Yep I agree.
> 
>> unless you want to do that yourself? In that case, please go ahead :)
> 
> It looks like there's a ticket open on an aspect of this issue already, but
> the discussion instead (of being about the lack of IP encapsulation) is
> about the choice of EHLO identifier, but this still seems like it might be
> the right place to talk about this bug?
> 
>    https://trac.torproject.org/projects/tor/ticket/13006

I've created a pull request for this:
https://github.com/ioerror/torbirdy/pull/27

I'll need to test possible leaks on the EHLO anyway and will report back.

Cheers!