[Pkg-privacy-maintainers] Bug#811266: pulseaudio: log is flooded sometimes when combined with torsocks (torify)

[Felipe Sateler]

Control: reassign -1 torsocks
Control: found -1 2.1.0-2
Control: retitle -1 torsocks: accept{,4} should allow a NULL addr parameter

On 19 January 2016 at 14:58, Andreas B. Mundt <andi at debian.org> wrote:
> Hi Felipe,
>
> thanks for your fast reply.
>
> On Mon, Jan 18, 2016 at 04:16:19PM -0300, Felipe Sateler wrote:
>> On 18 January 2016 at 15:54, Andreas B. Mundt <andi at debian.org> wrote:
>
> [...]
>
>> Hmm, so this suggests that there is some problem when autospawning
>> pulseaudio. The contents of ~/.config/pulse/client.conf include only
>> the autospawn setting, right? This would be consistent with the
>> observation that it only breaks the first time since boot.
>
> Yes, normally ~/.config/pulse/client.conf does not exist here.
>
>> Can you reproduce the problem if you try using mpg321 without torify
>> first, and then with torify?
>
> Indeed.  I can reproduce always with:
>
>          killall pulseaudio
>          torify mpg321 http://mp3stream1.apasf.apa.at:8000
>
> whereas:
>
>          killall pulseaudio
>          mpg321 http://mp3stream1.apasf.apa.at:8000
>          torify mpg321 http://mp3stream1.apasf.apa.at:8000
>
> works fine.

The problem is that torsocks does not allow a NULL addr pointer in the
accept{,4} wrappers[1], and sets errno to EFAULT in that case. The
manpage of accept4[2] explicitly allows setting addr to NULL, so the
torsocks wrapper should allow it.

AFAICT, the version in stable has this problem as well.

[1] http://sources.debian.net/src/torsocks/2.1.0-2/src/lib/accept.c/#L114
[2] http://linux.die.net/man/2/accept4


-- 

Saludos,
Felipe Sateler