[Pkg-privacy-maintainers] New torbrowser-launcher upstream version is out Was: Bug#803171: this only affects one profile in complaint mode

[Holger Levsen]

Hi,

On Mon, Jul 11, 2016 at 04:55:00PM +0000, u wrote:
> We did not agree on that, however, if you look at the state of the
> pristine-tar branch it's simply a fact that the latest versions did not
> use it anymore. Unless I miss something here. This branch is not even
> present at
> https://anonscm.debian.org/git/pkg-privacy/packages/torbrowser-launcher.git
> anymore.
> 
> I *do* have a local copy of the pristine-tar branch from about a year
> ago, when I last worked on this package. So, either somebody takes care
> of putting the branch back it into shape or we disable it in gbp.conf.
> That's what I have done for the time being.
> 
> Do you actually use pristine-tar? If yes, maybe you need to push your
> branch with the latest additions, and then I'll happily take care of
> updating it. In any case, I guess that one should also document how to
> update this package correctly in debian/README.source.
 
my point is: we agreed on this workflow, because we thought this was the
best possible workflow for this. so I would expect a discussion before
officially burying it.

(and no, I havent used pristine-tar here recently, in fact I think I did
the last upload ignoring pristine-tar. but this was ment as a temporal
thing, to get the upload done.)

and as I tried to say in my first/last mail on this: I dont mind the
change. I mind the change without discussing it first.

> > Then, as a minor nitpick, I wouldn't have done f8b9b90a1 as a revert,
> > but rather as a simple file removal and normal commit. And then, I
> > would have mentioned this in debian/changelog: "removed
> > $description/$path patch as it has been merged upstream". (And that's
> > actually a less minor comment…)
> 
> I agree that it's not very beautiful.
> 
> However that patch was my own addition before I merged the current tag,
> and was not present in the previous version of tbl.

ah. (if the patch wasnt pushed before it would have been better to
rebase it out…)
 
> That is not correct. This english language bug is a new feature. It was
> not present before. Thus I fail to see how it can break current
> behaviour TBH.
 
this new feature breaks 7 tests on
https://jenkins.debian.net/view/torbrowser/ and as I also understood
you, it breaks the workflow of simply starting torbrowser with the
default launcher settings for some locales…

but really, breaking the tests is enough for *me* not to upload this. I
like the tests to be working as they have been very useful detecting
breakge in the last year… (or knowing things are *not* broken despite
user complaints…)
 
> If this is now actually a bullhead contest, I'm out. _Out_ as in "please
> remove me from Uploaders".

Same here.

:-(

I can't believe you're thinking I'm interested in a "bullhead contest"
instead of trying to do whats best for our users and free software.


-- 
cheers,
	Holger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 811 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-privacy-maintainers/attachments/20160712/44ce28a6/attachment-0001.sig>