[Pkg-privacy-maintainers] Bug#831154: hexchat-otr: FTBFS with GCC 6: src/otr_util.c:111:5: error: format not a string literal, argument types not checked [-Werror=format-nonliteral]

[Lucas Nussbaum]

Source: hexchat-otr
Version: 0.2.0-4
Severity: serious
Tags: stretch sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20160713 qa-ftbfs
Justification: FTBFS with GCC 6 on amd64

Hi,

During a rebuild of all packages in sid using the gcc-defaults package
available in experimental to make GCC default to version 6, your package failed
to build on amd64. For more information about GCC 6 and Stretch, see:
- https://wiki.debian.org/GCC6
- https://lists.debian.org/debian-devel-announce/2016/06/msg00007.html

Relevant part (hopefully):
> /bin/bash ./libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I.   -Wdate-time -D_FORTIFY_SOURCE=2  -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -std=gnu99 -funsigned-char -fPIE -fPIC -Wall -Wextra -Wconversion -Winline -Wno-padded -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Werror=implicit-function-declaration -Werror=pointer-arith -Werror=init-self -Werror=format=2 -Werror=missing-include-dirs -Werror=date-time -c -o src/otr_la-otr_util.lo `test -f 'src/otr_util.c' || echo './'`src/otr_util.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -std=gnu99 -funsigned-char -fPIC -Wall -Wextra -Wconversion -Winline -Wno-padded -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Werror=implicit-function-declaration -Werror=pointer-arith -Werror=init-self -Werror=format=2 -Werror=missing-include-dirs -Werror=date-time -c src/otr_util.c  -fPIC -DPIC -o src/.libs/otr_la-otr_util.o
> src/otr_util.c: In function 'context_add_app_info':
> src/otr_util.c:111:5: error: format not a string literal, argument types not checked [-Werror=format-nonliteral]
>      formats[TXT_OTR_BETTER_TWO].def, co->accountname);
>      ^~~~~~~
> cc1: some warnings being treated as errors
> make[2]: *** [src/otr_la-otr_util.lo] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2016/07/13/hexchat-otr_0.2.0-4_unstable_gcc6.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.