[Pkg-privacy-maintainers] Bug#832821: when configured address contains .onion, things go wrong

[Donncha O'Cearbhaill]

On Fri, 29 Jul 2016 07:17:00 +0000 Peter Palfrader <weasel at debian.org>
wrote:
> Package: onionbalance
> Version: 0.1.4-1~bpo8+1
> Severity: normal
> 
> Hi,
> 
> I had this config:
> 
> |  - # ftp.debian.org via vwakviie2ienjx6t.onion
> |    key: private_keys/ftp.debian.org.key
> |    instances:
> |      - address: kpw6vrobjzz4yd7x.onion
> |        name: klecker-ftp.debian.org
> 
> And shortly after start up I would get
> | [WARNING]: Received a descriptor with address kpw6vrobjzz4yd7x.onion that did not match any configured service instances.
> 
> Digging a little, suggests that onionbalance would try to set up things
> and fetch the descriptor for kpw6vrobjzz4yd7x.onion.  However, when it
> was getting the descriptor, it ended up being confused about the .onion
> extensioni.  I added some log lines to descriptor.py's descriptor_received():
> 
> | [WARNING]: [weasel] iterating over configured services
> | [WARNING]: [weasel]  service <onionbalance.service.Service object at 0x7f03bff246d8>
> | [WARNING]: [weasel]   instance <onionbalance.instance.Instance object at 0x7f03bff24588>
> | [WARNING]: [weasel]    onion_address kpw6vrobjzz4yd7x.onion
> | [WARNING]: [weasel]    descriptor_onion_address kpw6vrobjzz4yd7x
>                        ^^^^^^^^^^ of course, == will fail between these.
> | [WARNING]: Received a descriptor with address kpw6vrobjzz4yd7x.onion that did not match any configured service instances.
> 
> I suggest that onionbalance either handle .onion as address everywhere,
> or that it reject them earlier.

I have fixed this bug upstream in
https://github.com/DonnchaC/onionbalance/issues/37. The fix has not been
included in a release yet, but it is scheduled for release 0.1.5.

Regards,
Donncha