[Pkg-privacy-maintainers] Bug#842021: torbrowser-launcher: Installer crashes if trying to enforce installation of EN version on non-EN user session

[Andreas]

Package: torbrowser-launcher
Version: 0.2.6-2
Severity: normal

Dear Maintainer,

When running the launcher for the first time I decided to check

[x] Force downloading English version of Tor Browser

After successfully downloading the English package, checking and unzipping the
files, the install script crashes.

Command line output:

----8<----

Tor Browser Launcher
By Micah Lee, licensed under MIT
version 0.2.6
https://github.com/micahflee/torbrowser-launcher
Downloading over Tor
Downloading and installing Tor Browser for the first time.
Downloading
https://dist.torproject.org/torbrowser/update_2/release/Linux_x86_64-gcc3/x/en-
US
Latest version: 6.0.5
Downloading https://www.torproject.org/dist/torbrowser/6.0.5/tor-browser-
linux32-6.0.5_en-US.tar.xz.asc
Downloading https://www.torproject.org/dist/torbrowser/6.0.5/tor-browser-
linux32-6.0.5_en-US.tar.xz
Verifying signature
Extracting tor-browser-linux32-6.0.5_en-US.tar.xz
Running /home/andreas/.local/share/torbrowser/tbb/i686/tor-browser_de/start-
tor-browser.desktop
Unhandled Error
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/web/_newclient.py", line 916,
in dispatcher
    return func(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/twisted/web/_newclient.py", line 1480,
in _finishResponse_WAITING
    self._giveUp(Failure(reason))
  File "/usr/lib/python2.7/dist-packages/twisted/web/_newclient.py", line 1533,
in _giveUp
    self._disconnectParser(reason)
  File "/usr/lib/python2.7/dist-packages/twisted/web/_newclient.py", line 1521,
in _disconnectParser
    parser.connectionLost(reason)
--- <exception caught here> ---
  File "/usr/lib/python2.7/dist-packages/twisted/web/_newclient.py", line 537,
in connectionLost
    self.response._bodyDataFinished()
  File "/usr/lib/python2.7/dist-packages/twisted/web/_newclient.py", line 916,
in dispatcher
    return func(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/twisted/web/_newclient.py", line 1169,
in _bodyDataFinished_CONNECTED
    self._bodyProtocol.connectionLost(reason)
  File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py", line
329, in connectionLost
    self.all_done(reason)
  File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py", line
346, in response_finished
    self.run_task()
  File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py", line
276, in run_task
    self.run_task()
  File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py", line
282, in run_task
    self.verify()
  File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py", line
491, in verify
    self.run_task()
  File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py", line
286, in run_task
    self.extract()
  File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py", line
531, in extract
    self.run_task()
  File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py", line
290, in run_task
    self.run()
  File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py", line
547, in run
    if not self.check_min_version():
  File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py", line
535, in check_min_version
    for line in open(self.common.paths['tbb']['versions']).readlines():
exceptions.IOError: [Errno 2] Datei oder Verzeichnis nicht gefunden:
'/home/*/.local/share/torbrowser/tbb/i686/tor-
browser_de/Browser/TorBrowser/Docs/sources/versions'

---->8----

Obviously, the installer tries ot access files in the */tor-browser_de/*
folder, even though it installed the English version as enforced. Looks like
checking the option for the English version does not set the corresponding
value to "en" instead of (in my case) "de".

Regards

Andreas





-- System Information:
Debian Release: stretch/sid
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'testing'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 4.7.0-1-686-pae (SMP w/1 CPU core)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages torbrowser-launcher depends on:
ii  ca-certificates  20160104
ii  gnupg            2.1.15-4
ii  python-gtk2      2.24.0-5.1
ii  python-lzma      0.5.3-3
ii  python-parsley   1.2-1
ii  python-psutil    4.3.1-1
ii  python-twisted   16.3.0-1
ii  python-txsocksx  1.15.0.2-1
pn  python:any       <none>
ii  wmctrl           1.07-7

Versions of packages torbrowser-launcher recommends:
ii  tor  0.2.8.9-1

Versions of packages torbrowser-launcher suggests:
pn  apparmor       <none>
pn  python-pygame  <none>

-- no debconf information