[Pkg-privacy-maintainers] Bug#849727: Adopting seahorse-nautilus?

[u]

Hi,

intrigeri:
> Carlos Maddela:

> Great, thanks! Do you think these changes are appropriate / safe for
> Stretch? If you think so, then I'm happy to upload after someone has
> reviewed your changes and made the additional ones that are necessary
> adopted the package under the team's umbrella. Ulrike, perhaps?

I've created the corresponding Git repository and Carlos has imported
his changes in there. I've reviewed the packaging and Carlos did a lot
of great work there. I can confirm that everything builds fine.

See Vcs-Git:
https://anonscm.debian.org/git/pkg-privacy/packages/seahorse-nautilus.git
Vcs-Browser:
https://anonscm.debian.org/cgit/pkg-privacy/packages/seahorse-nautilus.git

There are some new patches for which I have not enough technical
expertise in order to evaluate them, so this should be done by somebody
else.

In the patches, I think we could have some more specific information
about what "more recent versions" is supposed to mean:

In debian/patches/update-Makefile-am.patch
" This allows the Makefile.am files to work with more recent versions of
  automake without warnings."

And the "Origin: vendor" is not necessary if the Author field is present
I believe.

There is a false positive in older versions of lintian reporting "E
missing-build-dependency-for-dh_-command":
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=835449

And here are some other errors I get, but I'm unsure if this is because
I use Jessie's lintian.

$ lintian --pedantic seahorse-nautilus_3.11.92-2_amd64.changes
E: seahorse-nautilus-dbgsym: extended-description-is-empty
W: seahorse-nautilus-dbgsym: debug-package-should-be-named-dbg
usr/lib/debug/.build-id/

Everything else looks good. Let's continue the discussion publicly on
the pkg-privacy list so that others can participate.

Could you take this over from here, intrigeri? My DD account is still
waiting for FrontDesk (although eventually after your own review I might
be able to do a first sponsored upload - just for the sake of learning
to do that properly.)

Cheers!
ulrike