[Pkg-privacy-maintainers] Fwd: [Pkg-privacy-commits] [onioncircuits] 02/02: Add AppArmor profile for onioncircuits and install it.

[Sascha Steinbiss]

Hi Ulrike,

> the commit importing the apparmor profile is a reference to a commit I
> made upstream FYI. I don't know if you want to prepare a new upload for
> Debian with this profile, after reviewing it, or if you want me to
> prepare this?

I don't mind if you prepare an upload in general :) Thanks!

However, I was wondering why you added the apparmor profile to
upstream's code in master? As it is a Debian/Tails specific addition, I
would have expected it to be somewhere under debian/ and installed from
there. Placing it outside debian/ breaks building with
--git-pristine-tar for me as the contents of master no longer match
what's in the tarball:

[...]
dpkg-source: info: building onioncircuits using existing
./onioncircuits_0.4.orig.tar.gz
dpkg-source: info: local changes detected, the modified files are:
 onioncircuits/apparmor/usr.bin.onioncircuits
[...]

I guess might also help contacting Alan to include the profile in future
upstream releases.

Cheers
Sascha

> -------- Forwarded Message --------
> Subject: [Pkg-privacy-commits] [onioncircuits] 02/02: Add AppArmor
> profile for onioncircuits and install it.
> Date: Sun, 19 Mar 2017 20:44:43 +0000
> From: Ulrike Uhlig <ulrike at moszumanska.debian.org>
> Reply-To: Ulrike Uhlig <u at 451f.org>
> To: pkg-privacy-commits at lists.alioth.debian.org
> 
> This is an automated email from the git hooks/post-receive script.
> 
> ulrike pushed a commit to branch master
> in repository onioncircuits.
> 
> commit 259d79339d7761cd60c6cd97b50ffc2a9ed9d079
> Author: Ulrike Uhlig <u at 451f.org>
> Date:   Sun Mar 19 21:43:07 2017 +0100
> 
>     Add AppArmor profile for onioncircuits and install it.
>         https://labs.riseup.net/code/issues/12170
> ---
>  debian/rules | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/debian/rules b/debian/rules
> index e9d6b17..3f02188 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -6,6 +6,10 @@ UPSTREAM_VERSION=$(shell dpkg-parsechangelog -SVersion
> | cut -d- -f1)
>  %:
>  	dh $@ --with python3 --buildsystem=pybuild
>  +override_dh_install:
> +	install -m 644 debian/apparmor/usr.bin.onioncircuits
> debian/onioncircuits/etc/apparmor.d/usr.bin.onioncircuits
> +	dh_apparmor --profile-name=usr.bin.onioncircuits -ponioncircuits
> +
>  override_dh_installman:
>  	help2man -S 'Tails project' \
>  	  -n 'display Tor circuits and streams' \
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-privacy-maintainers/attachments/20170320/a3d22f73/attachment.sig>