[Pkg-privacy-maintainers] Bug#859476: onionbalance: onionbalance.service fails to add dependencies

[Helle Vaanzinn]

Package: onionbalance
Severity: important
Tags: patch

Dear Maintainer,

systemd service fails, due to erroneous comma in `After` field:

$ journalctl | grep onionbalance
Mar 15 00:10:51 lab16 systemd[1]: [/lib/systemd/system/onionbalance.service:8]
Failed to add dependency on network.target,, ignoring: Invalid argument

$ cat /lib/systemd/system/onionbalance.service
# OnionBalance systemd target

[Unit]
Description=OnionBalance - Tor Onion Service load balancer
Documentation=man:onionbalance
Documentation=file:///usr/share/doc/onionbalance/html/index.html
Documentation=https://github.com/DonnchaC/onionbalance
After=network.target, tor.target
Wants=network-online.target
ConditionPathExists=/etc/onionbalance/config.yaml

[Service]
Type=simple
PIDFile=/run/onionbalance.pid
Environment="ONIONBALANCE_LOG_LOCATION=/var/log/onionbalance/log"
ExecStartPre=/usr/bin/install -Z -m 02750 -o onionbalance -g adm -d
/var/run/onionbalance
ExecStart=/usr/sbin/onionbalance -c /etc/onionbalance/config.yaml
ExecReload=/usr/sbin/onionbalance reload
ExecStop=-/sbin/start-stop-daemon --quiet --stop --retry=TERM/5/KILL/5
--pidfile /run/onionbalance.pid
TimeoutStopSec=5
KillMode=mixed

EnvironmentFile=-/etc/default/%p
User=onionbalance
PermissionsStartOnly=true
Restart=on-abnormal
RestartSec=2s
LimitNOFILE=65536

# Hardening
# AppArmorProfile=system_onionbalance
# CapabilityBoundingSet=CAP_NET_BIND_SERVICE CAP_CHOWN CAP_FOWNER
NoNewPrivileges=yes
PrivateDevices=yes
PrivateTmp=yes
ProtectHome=yes
ProtectSystem=full
ReadOnlyDirectories=/
ReadWriteDirectories=-/proc
ReadWriteDirectories=-/var/log/onionbalance
ReadWriteDirectories=-/var/run

[Install]
WantedBy=multi-user.target

The same typo (I assume it is just that) exists in all available Debian
onionbalance packages I checked:

jessie-backports 0.1.4-1~bpo8+1
stretch 0.1.6-1
sid 0.1.6-1
experimental 0.1.7-1

Proposed patch simply removes the erroneous comma.
Originally filed as
https://bugs.launchpad.net/ubuntu/+source/onionbalance/+bug/1672901

Regards.



-- System Information:
Debian Release: stretch/sid
  APT prefers xenial-updates
  APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500,
'xenial'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 4.10.0-ck1 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: systemd-service.patch
Type: text/x-diff
Size: 409 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-privacy-maintainers/attachments/20170404/a2a730f7/attachment.patch>