[Pkg-privacy-maintainers] Bug#873036: new upstream release (0.19.3) required for magic-wormhole

[Antoine Beaupre]

Source: txtorcon
Version: 0.18.0
Severity: normal

Hi!

I would like to get help to see the latest version of txtorcon
(0.19.3) arrive in the archive. It is necessary to make tor support
work properly in magic-wormhole, and I suspect in other applications.

For example, wormhole requires the bugfix from this issue, shipped
with 0.19.3:

https://github.com/meejah/txtorcon/issues/237

0.19.2 also introduces py3 support, which we use in magic-wormhole as
well.

I have tried to prepare a NMU to do just that, using a rather naive
"gbp import-orig --uscan", but that failed. Looks like upstream added
the "automat" build-depend which makes tests fail. But even after
adding that to the build-deps, tests fail with:


make test
make[2]: Entering directory '/<<PKGBUILDDIR>>'
Makefile:15: warning: overriding recipe for target 'diagrams'
Makefile:12: warning: ignoring old recipe for target 'diagrams'
PYTHONPATH=. trial --reporter=text test
Unhandled Error
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/scripts/trial.py", line 472, in postOptions
    _BasicOptions.postOptions(self)
  File "/usr/lib/python2.7/dist-packages/twisted/scripts/trial.py", line 382, in postOptions
    self['reporter'] = self._loadReporterByName(self['reporter'])
  File "/usr/lib/python2.7/dist-packages/twisted/scripts/trial.py", line 369, in _loadReporterByName
    for p in plugin.getPlugins(itrial.IReporter):
  File "/usr/lib/python2.7/dist-packages/twisted/plugin.py", line 213, in getPlugins
    allDropins = getCache(package)
--- <exception caught here> ---
  File "/usr/lib/python2.7/dist-packages/twisted/plugin.py", line 171, in getCache
    provider = pluginModule.load()
  File "/usr/lib/python2.7/dist-packages/twisted/python/modules.py", line 392, in load
    return self.pathEntry.pythonPath.moduleLoader(self.name)
  File "/usr/lib/python2.7/dist-packages/twisted/python/reflect.py", line 300, in namedAny
    topLevelPackage = _importAndCheckStack(trialname)
  File "/usr/lib/python2.7/dist-packages/twisted/python/reflect.py", line 239, in _importAndCheckStack
    return __import__(importName)
  File "/<<PKGBUILDDIR>>/twisted/plugins/txtorcon_endpoint_parser.py", line 1, in <module>
    import txtorcon
  File "/<<PKGBUILDDIR>>/txtorcon/__init__.py", line 16, in <module>
    from txtorcon.controller import connect
  File "/<<PKGBUILDDIR>>/txtorcon/controller.py", line 35, in <module>
    from txtorcon.endpoints import TorClientEndpoint, _create_socks_endpoint
  File "/<<PKGBUILDDIR>>/txtorcon/endpoints.py", line 14, in <module>
    from txtorcon.socks import TorSocksEndpoint
  File "/<<PKGBUILDDIR>>/txtorcon/socks.py", line 61, in <module>
    class _SocksMachine(object):
  File "/<<PKGBUILDDIR>>/txtorcon/socks.py", line 408, in _SocksMachine
    outputs=[_send_version],
  File "/usr/lib/python2.7/dist-packages/automat/_methodical.py", line 62, in upon
    self.machine._oneTransition(self, input, enter, outputs, collector)
  File "/usr/lib/python2.7/dist-packages/automat/_methodical.py", line 255, in _oneTransition
    tuple(outputTokens))
  File "/usr/lib/python2.7/dist-packages/automat/_core.py", line 74, in addTransition
    (inState, inputSymbol, outState, tuple(outputSymbols))
exceptions.TypeError: unhashable type: 'MethodicalState'

EEEEEEEEEEEEEEEEEE
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/trial/runner.py", line 508, in loadPackage
    module = modinfo.load()
  File "/usr/lib/python2.7/dist-packages/twisted/python/modules.py", line 392, in load
    return self.pathEntry.pythonPath.moduleLoader(self.name)
  File "/usr/lib/python2.7/dist-packages/twisted/python/reflect.py", line 300, in namedAny
    topLevelPackage = _importAndCheckStack(trialname)
  File "/usr/lib/python2.7/dist-packages/twisted/python/reflect.py", line 247, in _importAndCheckStack
    reraise(excValue, excTraceback)
  File "/<<PKGBUILDDIR>>/test/test_addrmap.py", line 7, in <module>
    from txtorcon.addrmap import AddrMap
  File "/<<PKGBUILDDIR>>/txtorcon/__init__.py", line 16, in <module>
    from txtorcon.controller import connect
  File "/<<PKGBUILDDIR>>/txtorcon/controller.py", line 35, in <module>
    from txtorcon.endpoints import TorClientEndpoint, _create_socks_endpoint
  File "/<<PKGBUILDDIR>>/txtorcon/endpoints.py", line 14, in <module>
    from txtorcon.socks import TorSocksEndpoint
  File "/<<PKGBUILDDIR>>/txtorcon/socks.py", line 24, in <module>
    from txtorcon import util
exceptions.ImportError: cannot import name util

[...]

I'm obviously hesitant in just disabling tests, so I'm turning to you
for help!

Let me know if you need more information.

Thanks!

A.
-- System Information:
Debian Release: 9.1
  APT prefers stable
  APT policy: (500, 'stable'), (1, 'experimental'), (1, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8), LANGUAGE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)