[Pkg-privacy-maintainers] Bug#884419: torbrowser-launcher: debian/rules clean does not run dh_clean

[Andreas Beckmann]

Source: torbrowser-launcher
Version: 0.2.8-5
Severity: serious
Justification: Policy 4.9

Hi,

from the attached pbuilder --twice buildlog after the first build has finished:

 dpkg-source --before-build torbrowser-launcher-0.2.8
dpkg-buildpackage: info: host architecture amd64
 fakeroot debian/rules clean
dh clean --with python2 --buildsystem=python_distutils
   dh_auto_clean -O--buildsystem=python_distutils
        python setup.py clean -a
running clean
removing 'build/lib.linux-x86_64-2.7' (and everything under it)
'build/bdist.linux-x86_64' does not exist -- can't clean it
removing 'build/scripts-2.7' (and everything under it)
        find . -name \*.pyc -exec rm {} \+
   debian/rules override_dh_clean
make[1]: Entering directory '/build/torbrowser-launcher-0.2.8'
rm -rf share/locale/
make[1]: Leaving directory '/build/torbrowser-launcher-0.2.8'
 dpkg-source -b torbrowser-launcher-0.2.8
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: error: unwanted binary file: debian/torbrowser-launcher/usr/share/man/man1/torbrowser-launcher.1.gz
dpkg-source: error: unwanted binary file: debian/torbrowser-launcher/usr/share/doc/torbrowser-launcher/changelog.Debian.gz
dpkg-source: error: unwanted binary file: debian/torbrowser-launcher/usr/share/doc/torbrowser-launcher/changelog.gz
dpkg-source: error: unwanted binary file: debian/torbrowser-launcher/usr/share/pixmaps/torbrowser.png
dpkg-source: error: unwanted binary file: debian/torbrowser-launcher/usr/share/torbrowser-launcher/modem.ogg
dpkg-source: error: unwanted binary file: debian/torbrowser-launcher/usr/share/locale/torbrowser-launcher.mo
dpkg-source: error: unwanted binary file: debian/torbrowser-launcher/usr/share/locale/ru/LC_MESSAGES/torbrowser-launcher.mo
dpkg-source: error: unwanted binary file: debian/torbrowser-launcher/usr/share/locale/pl/LC_MESSAGES/torbrowser-launcher.mo
dpkg-source: error: unwanted binary file: debian/torbrowser-launcher/usr/share/locale/nl/LC_MESSAGES/torbrowser-launcher.mo
dpkg-source: error: unwanted binary file: debian/torbrowser-launcher/usr/share/locale/hu/LC_MESSAGES/torbrowser-launcher.mo
dpkg-source: error: unwanted binary file: debian/torbrowser-launcher/usr/share/locale/fr/LC_MESSAGES/torbrowser-launcher.mo
dpkg-source: error: unwanted binary file: debian/torbrowser-launcher/usr/share/locale/cs/LC_MESSAGES/torbrowser-launcher.mo
dpkg-source: error: detected 12 unwanted binary files (add them in debian/source/include-binaries to allow their inclusion).
dpkg-buildpackage: error: dpkg-source -b torbrowser-launcher-0.2.8 subprocess returned exit status 29


Without calling dh_clean, all the temporary stuff in debian/ is retained,
but luckily dpkg-source chokes on unwanted binaries, refusing to create
a source package full of binary cruft.

The override_dh_clean target needs to call dh_clean in addition to any
further cleanup it does.


Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: torbrowser-launcher_0.2.8-5.log.gz
Type: application/gzip
Size: 6959 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-privacy-maintainers/attachments/20171215/7504ebe7/attachment.bin>